Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verilog rules in prelude #860

Open
rzig opened this issue Feb 27, 2025 · 2 comments
Open

Verilog rules in prelude #860

rzig opened this issue Feb 27, 2025 · 2 comments
Labels
prelude Related to integration/prelude

Comments

@rzig
Copy link

rzig commented Feb 27, 2025

Hey! I've been working on some hardware dev in Buck2 over the last several months and have built up a set of Verilog rules + rules for associated tools like Verilator. I'm not entirely sure of the process of adding things to the prelude, but I'd be interested in contributing these if there's interest.

@cormacrelf
Copy link
Contributor

I would recommend making a repo that works when loaded as an external cell. A very big advantage of external cells is that you don't need to go through review here to push tweaks. Not to be underestimated. And for users of the rules, they don't have to update prelude + buck2 to get those tweaks. Ultimately this is the lowest friction option. I don't think Meta is saying no to new prelude rules, but I think this way just works better.

There are rules repos out there like https://github.com/benbrittain/oci-rules, and others at the buck2 topic on github. There should probably be a buck2 documentation page to make these a bit more discoverable.

@mrkmndz
Copy link
Contributor

mrkmndz commented Mar 4, 2025

Hi @rzig! I'm from a DevInfra team at Meta that supports ASIC engineers with things like Verilog. I'd be happy to review the rules that you've put together and then we can advise you on what the best home for them would be.

To get started, you could either put up a PR against the prelude, or just share a repo where you have them written out.

cc @get9

@alexlian alexlian added the prelude Related to integration/prelude label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prelude Related to integration/prelude
Projects
None yet
Development

No branches or pull requests

4 participants