2023-10-15

prelude/rust: Process CARGO_MANIFEST_DIR during rustdoc test

Summary:
Rustdoc tests were not getting the `CARGO_MANIFEST_DIR` processing that
we do for all other compilations.

Reviewed By: dtolnay

Differential Revision: D50303301

fbshipit-source-id: 1c3171e7eccc2d1a0461aa93b65ff82ac880c8c0

2023-10-01

Augment command execution detail information to test run and test dis…

2023-09-15

native python: stop setting PAR_LAUNCH_TIMESTAMP

Summary:
This messes with cli telemetry

Created from CodeHub with https://fburl.com/edit-in-codehub

Reviewed By: itamaro

Differential Revision: D49275018

fbshipit-source-id: c6f2672f3f532fe865a8afb61e6f84af7a798522

2023-09-01

Return error from export_as

Summary: `export_as` may construct a type for the typechecker. Type construction may do internal consistency checks. Internal consistency checks may fail. When they fail, better error than panic.

Reviewed By: ianlevesque

Differential Revision: D48857597

fbshipit-source-id: 9339ad0a1e555d4cb5da95852ba6c77d9e4b2f2c

2023-08-15

Support coerced attrs value() and type

Summary:
You currently can't do anything with the `coerced_attr` except print them out. Let's implement the basic `type` and `value()` methods to work with coerced attrs, similar to how configured attrs has it.

Coerced attrs aren't really converted to `Value<'v>`s, which is why I think it's ok for this implementation to live in buck2_bxl crate, since that's the only place it would be used.

3 of the coerced attrs types (select, concat, and explicit configured dep) aren't well supported in this implementation, but let's at least support the majority of the coerced attrs for a first pass.

Reviewed By: scottcao

Differential Revision: D48323666

fbshipit-source-id: 16e93ed80b77d0d1804db5919547dd725e52d27a

2023-08-01

buck2/oss: use custom %TEMP% in CircleCI on Windows (#371)

Summary:
This helps to eliminate flakiness of doctests on Windows. Sometime they fail with:
```
error: couldn't create a temp dir: The system cannot find the path specified. (os error 3) at path "C:\\Users\\CIRCLE~1.PAC\\AppData\\Local\\Temp\\rustdoctest86bH8a\\rmetawkIVXG"
```

Probably something in CircleCI runner messes with default TEMP dir, causing rustc to fail with this error.

Tested on 15 reruns of CircleCI job, they all succeeded, so I'm pretty confident this helps, although not sure exactly why. Before that, at least few out of 5 were failing.

Pull Request resolved: https://github.com/facebook/buck2/pull/371

Reviewed By: ndmitchell

Differential Revision: D47917932

fbshipit-source-id: 5d857e2f947e316e61f65764bb1f70b41bf275b8

2023-07-18

rustc_action: always use LF line-endings

Summary: CRLF is a pain. Avoid it.

Reviewed By: shayne-fletcher

Differential Revision: D47553486

fbshipit-source-id: e137526acb72b429f5dd29ff31f30431363783d5

2023-07-15

Simple refactor of prepare_cd_exe

Summary: Reduce duplication a little bit, make it easier to change things in the next diffs

Reviewed By: ianlevesque

Differential Revision: D47471859

fbshipit-source-id: 715a747cf8d3d0f29c02caa6c825323b0dbe2949

2023-07-11

Incompatible Changes

New Features

• New GitHub action job to tag and upload artifacts bi-monthly

Improvements

• Anonymous targets improvements
• A promise can be converted into an artifact, and used in default_outputs
• All collections are now supported correctly
  • attrs.source() is now supported, and can accept any bound artifacts
  • attrs.arg() is now supported via specifying a named parameter anon_target_compatible when declaring the attribute
  • attrs.exec_dep() is now supported