Skip to content

Commit 52f25a6

Browse files
Arman Ozturkfacebook-github-bot
Arman Ozturk
authored andcommitted
Log ingested IDs
Summary: Most of the unexpected experiment IDs have disappeared after our fix (D71122716), but we still have production requests with IDs. This change will help us investigate their origin. Differential Revision: D71200683 fbshipit-source-id: 1dc19ef3aad8c3ff9634b315fe00f3baa22d3ba1
1 parent bf219d2 commit 52f25a6

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

third-party/thrift/src/thrift/lib/hack/src/ThriftContextPropState.php

+17
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,23 @@ public static function initFromString(?string $s)[defaults]: void {
107107
$rid_set = true;
108108
}
109109

110+
if (
111+
!C\is_empty($tfm->experiment_ids ?? vec[]) &&
112+
coinflip(JustKnobs::getInt(
113+
'lumos/experimentation:ingested_exp_id_sample_rate',
114+
))
115+
) {
116+
FBLogger(
117+
'lumos_experimentation',
118+
'ingested experiment IDs from string',
119+
)
120+
->setBlameOwner('lumos')
121+
->warn(
122+
'Ingested TFM contains experiment IDs: %s',
123+
JSON::encode($tfm->experiment_ids),
124+
);
125+
}
126+
110127
self::get()->storage = $tfm;
111128
self::get()->dirty();
112129
}

0 commit comments

Comments
 (0)