Change __DynamicallyReferenced notice string

Reviewed By: jtwarren

Differential Revision: D71152713

fbshipit-source-id: 34dd7455d38fcd950e39a2886938dced87372e10

Author: vassilmladenov

hphp/runtime/base/strings.h

@@ -138,7 +138,8 @@ constexpr char MUST_BE_VALUE_TYPE[] = "Property %s of class %s is readonly, and
 constexpr char MUST_BE_ENCLOSED_IN_READONLY[] =
   "Property %s of class %s is readonly, but isn't enclosed in a readonly expression.";
 constexpr char MISSING_DYNAMICALLY_REFERENCED[] =
-  "Missing __DynamicallyReferenced attribute on class %s for classname_to_class";
+  "Class %s was loaded from a string, but it is missing the "
+  "__DynamicallyReferenced attribute";
 constexpr char CLASSNAME_TO_CLASS_NOEXIST_EXCEPTION[] =
   "Failed to load class from %s %s for classname_to_class.";
 constexpr char REFLECTION_MISS_CONSTANTS_FROM_INCLUDED_ENUMS[] =

hphp/test/slow/class-ptr/classname-to-class-launder.php.expectf

@@ -1,6 +1,6 @@
 class(C)
 
-Notice: Missing __DynamicallyReferenced attribute on class D for classname_to_class in %s/class-ptr/classname-to-class-launder.php on line 16
+Notice: Class D was loaded from a string, but it is missing the __DynamicallyReferenced attribute in %s/class-ptr/classname-to-class-launder.php on line 16
 class(D)
 lazyclass(C)
 class(C)

hphp/test/slow/class-ptr/classname-to-class.php.expectf

@@ -1,6 +1,6 @@
 class(C)
 
-Notice: Missing __DynamicallyReferenced attribute on class D for classname_to_class in %s/class-ptr/classname-to-class.php on line 13
+Notice: Class D was loaded from a string, but it is missing the __DynamicallyReferenced attribute in %s/class-ptr/classname-to-class.php on line 13
 class(D)
 lazyclass(C)
 class(C)

hphp/test/slow/class-ptr/emit-checktype-case.php.expectf

@@ -1,7 +1,7 @@
 
-Notice: Missing __DynamicallyReferenced attribute on class C for classname_to_class in %s/class-ptr/emit-checktype-case.php on line 9
+Notice: Class C was loaded from a string, but it is missing the __DynamicallyReferenced attribute in %s/class-ptr/emit-checktype-case.php on line 9
 hello
 bye
 
-Notice: Missing __DynamicallyReferenced attribute on class C for classname_to_class in %s/class-ptr/emit-checktype-case.php on line 13
+Notice: Class C was loaded from a string, but it is missing the __DynamicallyReferenced attribute in %s/class-ptr/emit-checktype-case.php on line 13
 bye

hphp/test/slow/class-ptr/readonly.php.expectf

@@ -1,5 +1,5 @@
 
-Notice: Missing __DynamicallyReferenced attribute on class C for classname_to_class in %s/class-ptr/readonly.php on line 4
+Notice: Class C was loaded from a string, but it is missing the __DynamicallyReferenced attribute in %s/class-ptr/readonly.php on line 4
 
 Notice: Class passed to classname type-hint in %s/class-ptr/readonly.php on line 16
 Done