Handle null params in the Interop TM layer #49873
Closed
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Summary: In the old architecture, when we were passing a `null` value as a parameter in a function that accepted nullable parameter, the null value was mapped to `nil` on iOS. After my changes in [d423679](facebook@d423679), in the New Architecture, through the interop layer, legacy modules were receiving an `NSNull` object instead of nil. This was breaking those modules which started crashing or observing undesired behavior. This change fixes the issue by making sure that, in those cases, a `nil` value is passed. Note that nested objects in the old architecture were correctly receiving NSNull, so nested objects were behaving correctly already. ## Changelog: [iOS][Fixed] - Properly pass `nil` for nullable parameters instead of `NSNull` for legacy modules Differential Revision: D70723460
|
This pull request was exported from Phabricator. Differential Revision: D70723460 |
|
This pull request was exported from Phabricator. Differential Revision: D70723460 |
cipolleschi
force-pushed
the
export-D70723460
branch
from
52c73e0 to
40d5002
Compare
|
This pull request has been merged in 619d5df. |
|
This pull request was successfully merged by @cipolleschi in 619d5df When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the old architecture, when we were passing a
nullvalue as a parameter in a function that accepted nullable parameter, the null value was mapped tonilon iOS.After my changes in d4236791e2, in the New Architecture, through the interop layer, legacy modules were receiving an
NSNullobject instead of nil.This was breaking those modules which started crashing or observing undesired behavior.
This change fixes the issue by making sure that, in those cases, a
nilvalue is passed.Note that nested objects in the old architecture were correctly receiving NSNull, so nested objects were behaving correctly already.
Changelog:
[iOS][Fixed] - Properly pass
nilfor nullable parameters instead ofNSNullfor legacy modulesDifferential Revision: D70723460