fix(dotgit): set publicheads correctly for transparent git mode #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 0ce7010 taught Sapling to use the correct public head based on the upstream default branch. However, this doesn't work when using the transparent git mode through `git clone`. This diff will correctly set the publicheads config when initializing sapling Test Plan: see test-git-clone-sets-publicheads.t
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
strager
reviewed
Oct 22, 2024
| let config = String::from_utf8(out.stdout)?; | ||
| let remotes_out = self | ||
| .git_cmd( | ||
| "ls-remote", &["--symref", ".", "HEAD"]) |
There was a problem hiding this comment.
This performs a network call, which might be unexpected or undesirable.
How about parsing the output of git rev-parse --symbolic refs/remotes/origin/HEAD instead?
There was a problem hiding this comment.
Good idea! If it's as robust as ls-remote then this will save a network call.
There was a problem hiding this comment.
You can use lookup_reference to resolve the reference without the spawning process overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
0ce7010 taught Sapling to use the correct public head based on the upstream
default branch. However, this doesn't work when using the transparent git mode
through
git clone.This diff will correctly set the publicheads config when initializing sapling
Test Plan: see test-git-clone-sets-publicheads.t