Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Image Pull Secret Spec for Deployment Template File #592

Open
danieljwood7 opened this issue Feb 4, 2025 · 2 comments
Open

Missing Image Pull Secret Spec for Deployment Template File #592

danieljwood7 opened this issue Feb 4, 2025 · 2 comments
Labels

Comments

@danieljwood7
Copy link

Hello,

There is an option to configure image pull secrets within the helm values here:
https://artifacthub.io/packages/helm/falcosecurity/falco-talon?modal=values

Image

However, the template file for the deployment doesn't have an option to pull in that value:
https://artifacthub.io/packages/helm/falcosecurity/falco-talon?modal=template&template=deployment.yaml

Image

I have tried various configurations in my values file to include:

imagePullSecrets:
- name: <name>

imagePullSecrets:
- <name>

imagePullSecrets:
  - name: <name>

imagePullSecrets:
  - <name>

However, the deployment never picks up the image pull secret.

I am using Falco Talon helm chart version 0.2.2.

Any ideas what the issue might be? Any help is appreciated.

@danieljwood7 danieljwood7 changed the title Missing Image Pull Secret Spec for Deployment Missing Image Pull Secret Spec for Deployment Template File Feb 4, 2025
@Issif
Copy link
Member

Issif commented Feb 5, 2025

Any ideas what the issue might be? Any help is appreciated.

The issue is simple, I forgot it. Do you want to submit a PR to fix, or do you want me to do it?

FYI, I'm preparing the release of a new release of Talon in the next days, I can include this fix in the my PR to update the version in the helm chart.

@danieljwood7
Copy link
Author

There is a current pull request addressing the issue: falcosecurity/charts#821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants