Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reason behind the all option #28

Open
2 tasks done
songkeys opened this issue May 10, 2023 · 3 comments
Open
2 tasks done

The reason behind the all option #28

songkeys opened this issue May 10, 2023 · 3 comments

Comments

@songkeys
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

I'm curious about the purpose of the all option. From the code, it appears that _deepmergeAll is the same as _deepmerge when two arguments are present, but can also be used for other n-argument cases. Could we use _deepmergeAll as the default option? Have I overlooked something?

@Uzlopak
Copy link
Contributor

Uzlopak commented May 10, 2023

The typescript typings are recursively determining the final object shape and thus can slow down your typescript transpilation and your IDE, like vscode.

@songkeys
Copy link
Author

Oh yes. I forgot about the typescript typing. Is ...args: T[] an option to solve this alternatively btw?

Meanwhile I think we should state clearly in the doc. The current description is too vague about this option.

@Uzlopak
Copy link
Contributor

Uzlopak commented May 10, 2023

You can provide a PR if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants