Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINT(GET-STARTED): Adapt for usage #21

Closed
6 of 10 tasks
Tracked by #37
azinit opened this issue Nov 23, 2021 · 4 comments
Closed
6 of 10 tasks
Tracked by #37

LINT(GET-STARTED): Adapt for usage #21

azinit opened this issue Nov 23, 2021 · 4 comments
Assignees
Milestone

Comments

@azinit
Copy link
Member

azinit commented Nov 23, 2021

Compare with ready solutions (effector, airbnb, ...)

  • Ignore redundant files in dist
  • Check basic usage (recommended + custom)
  • Other refinements
    • Remained docs refinements
  • LINT(GET-STARTED): Check customization of config #22
    • Refine customizing?
    • Refine configs splitting?
    • Add exporting of "bootstrap-init" helper function?
  • Rename rules (for preventing future problems):
    import-order
    - public-api-boundaries
    + public-api
    - layers-slices-boundaries
    + layers-slices
    • + Rename at README
  • Rename local rules/index.md to README.md
@azinit azinit changed the title LINT: Ignore redundant files in dist LINT(GET-STARTED): Adapt for usage Dec 11, 2021
@azinit azinit self-assigned this Dec 11, 2021
@azinit azinit added this to the 0.1.0-concept milestone Dec 12, 2021
@azinit azinit pinned this issue Dec 12, 2021
@azinit azinit unpinned this issue Dec 12, 2021
@azinit
Copy link
Member Author

azinit commented Dec 22, 2021

Setup DIST

630033c
2637689
5a049da

azinit added a commit that referenced this issue Dec 22, 2021
azinit added a commit that referenced this issue Dec 22, 2021
@azinit
Copy link
Member Author

azinit commented Dec 22, 2021

Usage check

Basic

image

Without public-api

image

Only import-order

image

Only public-api

image

Only layer-slices

image

@azinit
Copy link
Member Author

azinit commented Dec 22, 2021

@Krakazybik JFYI

image

@azinit
Copy link
Member Author

azinit commented Dec 22, 2021

С хоть какой либо кастомизацией проблемы, в виду ограничений eslint и конкретных плагинов
(т.к. правила просто перезаписываются разными конфигами)

Оставим проблему кастомизации до лучших времен, а пока для 0.1.0 прототипа должно хватить и того что есть

eslint/eslint#3175
eslint/eslint#9192

@azinit azinit closed this as completed Dec 22, 2021
azinit added a commit that referenced this issue Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant