Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transporting wipes lineup #6

Closed
opn opened this issue Jul 17, 2016 · 3 comments
Closed

Transporting wipes lineup #6

opn opened this issue Jul 17, 2016 · 3 comments

Comments

@opn
Copy link

opn commented Jul 17, 2016

Seems to me that there has been a change in the way the Transporter works with the lineup? Maybe nothing has changed but there is an issue. Dragging and dropping a url opens up a new item in the lineup - but not to the far right of th lineUp it replaces everything to the right of the page with the transporter on it.

This does not seem to work as well for me - I'm trying to transcribe a podcast, and it wipes the page - stopping the recording for instance. What would be great would be to either change it (back) so that it opens a page at the far right of the lineup, or enable a shift toggle to open it up at the end of the lineup on a drop?

@paul90
Copy link
Member

paul90 commented Jul 17, 2016

Looks as if the changes in #5 could be the cause.

Think the loss of handling of the shiftkey event in $page = $(e.target).parents('.page') unless e.shiftKey at 480df2c#diff-cfc390d14889bd70970f4cf33d9b1fa3L38 may be linked

@WardCunningham
Copy link
Member

The shift-click logic when in with 2819fae and then out again with 78eecfa.

I think this must have been a matter of my own hasty coding, temporarily disabling the event.shiftKey logic and forgetting to put it back now that there were two paths into the post routine.

I'm testing a fix now.

@paul90
Copy link
Member

paul90 commented Jul 16, 2019

Fixed by #7.

@paul90 paul90 closed this as completed Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants