Skip to content

Commit 212abc8

Browse files
authored
Merge pull request #7 from calebschoepp/improvements
Make some small improvements
2 parents 54fd956 + fbde51b commit 212abc8

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
otel-plugin
2+
otel

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Spin OTel Plugin
22

3-
This is a plugin that makes it easy to use OTel with Spin.
3+
This is a plugin that makes it easy to use OTel with Spin.
44

55
## Background
66

@@ -33,7 +33,7 @@ Alternatively, use the `spin pluginify` plugin to install from a fresh build. Th
3333

3434
```sh
3535
spin plugins install pluginify
36-
cargo build --release
36+
go build -o otel
3737
spin pluginify install
3838
```
3939

@@ -67,7 +67,7 @@ Dashboard for viewing metrics and logs:
6767
spin otel open grafana
6868
```
6969

70-
Dashboard for viewing trace data:
70+
Dashboard for viewing trace data:
7171

7272
```sh
7373
spin otel open jaeger
@@ -83,4 +83,4 @@ spin otel open prometheus
8383

8484
```sh
8585
spin otel cleanup
86-
```
86+
```
File renamed without changes.
File renamed without changes.
File renamed without changes.

cmd/root.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import (
44
"fmt"
55
"os"
66

7-
openSubCmds "github.com/fermyon/otel-plugin/cmd/open-subcmd"
7+
open "github.com/fermyon/otel-plugin/cmd/open"
88
"github.com/spf13/cobra"
99
)
1010

@@ -28,7 +28,7 @@ func init() {
2828
rootCmd.AddCommand(cleanUpCmd)
2929
rootCmd.AddCommand(setUpCmd)
3030
rootCmd.AddCommand(openCmd)
31-
openCmd.AddCommand(openSubCmds.GrafanaCmd)
32-
openCmd.AddCommand(openSubCmds.JaegerCmd)
33-
openCmd.AddCommand(openSubCmds.PrometheusCmd)
31+
openCmd.AddCommand(open.GrafanaCmd)
32+
openCmd.AddCommand(open.JaegerCmd)
33+
openCmd.AddCommand(open.PrometheusCmd)
3434
}

0 commit comments

Comments
 (0)