-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spin build
blocking uninterruptibly after failed execution
#2987
Comments
Looking at the original issue, the user report shows |
Yeah I can repro this with |
The problem happens because Ctrl+C handler sends a stop message (which happens correctly), but the loop that receives that message and responds to it by exiting is paused until after the first successful build (behaviour introduced in #2096). The build loop correctly circles back to the top and waits for changes (if you make a source code change, you'll see a rebuild), but until the first successful build, the stop message can't be processed. (After a successful build, the second loop is unpaused. It will pause again temporarily during builds, but always resumes whether the build succeeded or failed. So stop message processing may get delayed but will happen.)
|
The simplest fix seemed to be to have the Ctrl+C handler unpause the loop that receives the message. PR sent. |
As reported in fermyon/spin-js-sdk#313, a
spin build
Of note, this appeared (not yet verified) to have happened after the build subprocess returned:
Presumably something was handling SIGINT without terminating, though without being able to reproduce I'm not sure if that was Spin itself or some orphaned descendant process.
The text was updated successfully, but these errors were encountered: