-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow wildcard in http allowed_host #421
Comments
While I can see the necessity of something like this, I think we need to be cautious here. Allowing unrestricted outbound connections is pretty powerful; by default this would include outbound connections to the host's local network, |
My thought is that we should clearly document this and put a big WARNING sign when user is using the |
I would be happier if we made the string scarier 🙂 , maybe something like |
Will this be a string in |
I'm fine with it going in |
updated the pr to have |
We should have a
allowed_http_hosts = ["*"]
option to allow all all hosts. This is dangerous but in rare cases should be useful - like handling a webhook callback.The text was updated successfully, but these errors were encountered: