Update Wasmtime to 29.0.1 #3005
Conversation
alexcrichton
force-pushed
the
update-wasmtime
branch
from
7787d40 to
cb2401a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This commit updates the `wit-bindgen` crate version used in tests from 0.13.0 and 0.16.0 to 0.32.0. A significant number of changes have happened to `wit-bindgen` in the intervening releases which relatively radically change how, for example, exported functionality works. The goal here was to get all the tests compiling/passing again with the updated version of wit-bindgen, but this otherwise doesn't refactor things too much. Note that 0.32.0 isn't the latest `wit-bindgen` because the latest version needs other changes in WIT files to replace usage of `float32` with `f32` for example. The full update here will be deferred to spinframework#3005 Signed-off-by: Alex Crichton <[email protected]>
alexcrichton
force-pushed
the
update-wasmtime
branch
from
cb2401a to
af1d693
Compare
This comment was marked as resolved.
This comment was marked as resolved.
alexcrichton
force-pushed
the
update-wasmtime
branch
from
a3a770a to
a96973e
Compare
This commit updates Wasmtime from 25.0.3 to 29.0.1, the latest release of Wasmtime. This update is accompanied with few minor changes around bindings generation such as traits no longer needing `#[async_trait]`. Otherwise one of the main features is that the WITs included with Wasmtime's WASI implementation have been updated to 0.2.3 as well. This should continue to still work with guests using 0.2.2 and prior, though. Signed-off-by: Alex Crichton <[email protected]>
alexcrichton
force-pushed
the
update-wasmtime
branch
from
a96973e to
badc3b1
Compare
| interfaces: r#" | ||
| include wasi:http/[email protected]; | ||
| "#, | ||
| world: "wasi:http/[email protected]", |
There was a problem hiding this comment.
Do you recall why we needed the inline interface before? (and don't now)
There was a problem hiding this comment.
IIRC world only accepted "foo" before and not "foo:bar/baz". I also think that historically there wasn't a wasi:http/proxy world here but it was an amalgamation of other things. EIther that or I copy/pasted from elsewhere which had these motivations and this specific place didn't. Either way though I believe the two are equivalent and interfaces: ... was generating an error I wasn't quite sure why but world seemed to fix it.
| // NB: this is handling the historical behavior where Spin supported | ||
| // more than "just" this snaphsot of the proxy world but additionally | ||
| // other CLI-related interfaces. |
There was a problem hiding this comment.
Is this comment no longer relevant?
There was a problem hiding this comment.
Yeah I think that this is an outdated comment already because the comment implies there's more than one include or something beyond proxy but there's just the proxy world there now.
This commit updates Wasmtime from 25.0.3 to 29.0.1, the latest release of Wasmtime. This update is accompanied with few minor changes around bindings generation such as traits no longer needing
#[async_trait]. Thewit-parsercrate used throughout Wasmtime additionally no longer supportsfloat32in WIT files and instead requiresf32to be used (same forfloat64andf64)Otherwise one of the main features is that the WITs included with Wasmtime's WASI implementation have been updated to 0.2.3 as well. This should continue to still work with guests using 0.2.2 and prior, though.