rm: expand the index only when necessary

Originally, rm a pathspec that is out-of-cone in a sparse-index
environment, Git dies with "pathspec '<x>' did not match any files",
mainly because it does not expand the index so nothing is matched.

Expand the index when the pathspec needs an expanded index, i.e. the
pathspec contains wildcard that may need a full-index or the pathspec
is simply out-of-cone.

Signed-off-by: Shaoxuan Yuan <[email protected]>

Author: ffyuanda

builtin/rm.c

@@ -298,6 +298,10 @@ int cmd_rm(int argc, const char **argv, const char *prefix)
 
 	seen = xcalloc(pathspec.nr, 1);
 
+	if (the_index.sparse_index &&
+	    pathspec_needs_expanded_index(&the_index, &pathspec))
+		ensure_full_index(&the_index);
+
 	for (i = 0; i < active_nr; i++) {
 		const struct cache_entry *ce = active_cache[i];
 

t/t1092-sparse-checkout-compatibility.sh

@@ -1873,7 +1873,7 @@ test_expect_success 'rm pathspec inside sparse definition' '
 	test_all_match git status --porcelain=v2
 '
 
-test_expect_failure 'rm pathspec outside sparse definition' '
+test_expect_success 'rm pathspec outside sparse definition' '
 	init_repos &&
 
 	for file in folder1/a folder1/0/1 folder1/0/0/0