Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 for Web: PrivateChannel event listeners should support null type (all events) #1445

Open
kriswest opened this issue Nov 25, 2024 · 0 comments · May be fixed by #1446 or #1466
Open

FDC3 for Web: PrivateChannel event listeners should support null type (all events) #1445

kriswest opened this issue Nov 25, 2024 · 0 comments · May be fixed by #1446 or #1466
Labels
bug Something isn't working FDC3 for Web Browsers

Comments

@kriswest
Copy link
Contributor

kriswest commented Nov 25, 2024

FDC3 for Web currently offers request/response message types for both the new PrivateChannel.addEventListener function and the deprecated PrivateChannel.onAddContextListener/onUnsubscribe/onDisconnect functions

The current message schema for privateChannelAddEventListenerRequest doesn't currently support registering listeners for all event types, where the API function does (by passing null for the type argument):

addEventListener(type: PrivateChannelEventTypes  | null, handler: EventHandler): Promise<Listener>;
@kriswest kriswest added bug Something isn't working FDC3 for Web Browsers labels Nov 25, 2024
@kriswest kriswest changed the title FDC3 for Web: PrivateChannel event listeners should support null type (all events) + Old event listener messages are redundant FDC3 for Web: PrivateChannel event listeners should support null type (all events) Nov 25, 2024
@kriswest kriswest linked a pull request Dec 10, 2024 that will close this issue
16 tasks
@kriswest kriswest linked a pull request Dec 10, 2024 that will close this issue
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FDC3 for Web Browsers
Projects
None yet
1 participant