Disable

Author: ncooke3

.github/workflows/combine.yml

@@ -14,6 +14,9 @@
 
 name: combine
 
+permissions:
+  contents: read
+
 on:
   workflow_dispatch:
   pull_request:
@@ -72,31 +75,34 @@ jobs:
     - name: Build and test
       run:  scripts/third_party/travis/retry.sh scripts/build.sh CombineSwift ${{ matrix.target }} xcodebuild
 
-  storage-combine-integration:
-    # Don't run on private repo unless it is a PR.
-    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name)
-    env:
-      plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
-    runs-on: macos-15
-    steps:
-    - uses: actions/checkout@v4
-    - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
-      with:
-        cache_key: ${{ matrix.os }}
-    - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
-    - name: Setup Bundler
-      run: scripts/setup_bundler.sh
-    - name: Install xcpretty
-      run: gem install xcpretty
-    - name: Install Secret GoogleService-Info.plist
-      run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/storage-db-plist.gpg \
-          FirebaseStorage/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret"
-    - name: Install Credentials.h
-      run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Storage/Credentials.h.gpg \
-          FirebaseStorage/Tests/ObjCIntegration/Credentials.h "$plist_secret"
-    - name: Install Credentials.swift
-      run: |
-        scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Storage/Credentials.swift.gpg \
-          FirebaseStorage/Tests/Integration/Credentials.swift "$plist_secret"
-    - name: BuildAndTest # can be replaced with pod lib lint with CocoaPods 1.10
-      run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/build.sh StorageCombine all)
+# TODO: These tests started failing in Xcode 16. Using the iOS 18.4 simulator
+# crashes locally due to its networking issues. Using the iOS 18.3.1 simulator
+# works locally, but crashes on CI.
+#  storage-combine-integration:
+#    # Don't run on private repo unless it is a PR.
+#    if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || contains(fromJSON('["pull_request", "workflow_dispatch"]'), github.event_name)
+#    env:
+#      plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
+#    runs-on: macos-15
+#    steps:
+#    - uses: actions/checkout@v4
+#    - uses: mikehardy/buildcache-action@c87cea0ccd718971d6cc39e672c4f26815b6c126
+#      with:
+#        cache_key: ${{ matrix.os }}
+#    - uses: ruby/setup-ruby@354a1ad156761f5ee2b7b13fa8e09943a5e8d252 # v1
+#    - name: Setup Bundler
+#      run: scripts/setup_bundler.sh
+#    - name: Install xcpretty
+#      run: gem install xcpretty
+#    - name: Install Secret GoogleService-Info.plist
+#      run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/storage-db-plist.gpg \
+#          FirebaseStorage/Tests/Integration/Resources/GoogleService-Info.plist "$plist_secret"
+#    - name: Install Credentials.h
+#      run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Storage/Credentials.h.gpg \
+#          FirebaseStorage/Tests/ObjCIntegration/Credentials.h "$plist_secret"
+#    - name: Install Credentials.swift
+#      run: |
+#        scripts/decrypt_gha_secret.sh scripts/gha-encrypted/Storage/Credentials.swift.gpg \
+#          FirebaseStorage/Tests/Integration/Credentials.swift "$plist_secret"
+#    - name: BuildAndTest # can be replaced with pod lib lint with CocoaPods 1.10
+#      run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/build.sh StorageCombine all)

scripts/build.sh

@@ -321,14 +321,13 @@ case "$product-$platform-$method" in
     fi
     ;;
 
-  # TODO(ncooke3): Avoids 18.4 failures. Remove -sdk and -destination flags and replace with "${xcb_flags[@]}"
   CombineSwift-*-xcodebuild)
     pod_gen FirebaseCombineSwift.podspec --platforms=ios
     RunXcodebuild \
       -workspace 'gen/FirebaseCombineSwift/FirebaseCombineSwift.xcworkspace' \
       -scheme "FirebaseCombineSwift-Unit-unit" \
-      -sdk 'iphonesimulator' \
-      -destination 'platform=iOS Simulator,name=iPhone 16,OS=18.3.1' \
+      "${xcb_flags[@]}" \
+      build \
       test
     ;;