Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cofunction += Cofunction leads to DeprecationWarnings #3871

Open
jrmaddison opened this issue Nov 19, 2024 · 2 comments · May be fixed by #3898
Open

BUG: Cofunction += Cofunction leads to DeprecationWarnings #3871

jrmaddison opened this issue Nov 19, 2024 · 2 comments · May be fixed by #3898
Labels

Comments

@jrmaddison
Copy link
Contributor

Describe the bug

import warnings

warnings.simplefilter("default")

import firedrake as fd

mesh = fd.UnitIntervalMesh(1)
space = fd.FunctionSpace(mesh, "DG", 0)

u = fd.Cofunction(space.dual())
u += fd.Cofunction(space.dual())

leads to the warnings

/home/jmaddis2/build/firedrake/firedrake/src/PyOP2/pyop2/types/dat.py:408: DeprecationWarning: Expression.index(i) is deprecated and will be removed in 2H2025. Use 'expr[i] 'instead.
  lhs = _self.index(i)
/home/jmaddis2/build/firedrake/firedrake/src/PyOP2/pyop2/types/dat.py:416: DeprecationWarning: Expression.index(i) is deprecated and will be removed in 2H2025. Use 'expr[i] 'instead.
  rhs = _other.index(i)

Expected behavior
No warning.

Environment:
Ubuntu 24.04, new Firedrake build.

@jrmaddison jrmaddison added the bug label Nov 19, 2024
@Ig-dolci
Copy link
Contributor

Does this warning belong to one of the loopy related warnings, @connorjward?

@connorjward
Copy link
Contributor

This is a result of the update to pymbolic 2024.1. Since we are currently trying to move PyOP2 into the Firedrake repository I think fixing this should wait until that happens.

@connorjward connorjward linked a pull request Nov 29, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants