Add functionality to print patch statistics in ASMStarPC and friends #3875
Conversation
| V = get_function_space(dm) | ||
|
|
||
| # Obtain patches from user defined function | ||
| ises = self.get_patches(V) |
There was a problem hiding this comment.
It feels slightly extravagant to completely recompute the patch indices just for the sake of this monitor, but it is true that we don't stash these anywhere convenient for us to find. Is it worth stashing them in __init__ so that we don't need to recompute them here?
There was a problem hiding this comment.
I agree it's a bit wasteful. I agree we could stash them in __init__ if the option is present. I'll make this change.
There was a problem hiding this comment.
Isn't the correct approach here to compute the statistics during __init__ if the options are present? Then just stash the statistics to save memory.
|
|
|
This is a really useful option, thanks @pefarrell. Any chance you could add the mean patch size too? Could be useful to know if the min/max are particular outliers or not. |
We often would like to know what kind of sizes of patch problems we are dealing with in ASMStarPC and friends.
When using
-snes_view, PETSc prints out the size of the first patch on the first processor, but this isn't all that useful; really we want the minimum and maximum.This adds an option
-pc_star_print_patch_statisticsthat computes the minimum and maximum patch sizes and prints them out in the viewer, if requested.