Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Only Engine API server modules are initialized in the Binary #63

Closed
0xOsiris opened this issue Jan 28, 2025 · 3 comments · Fixed by #69
Closed

Bug: Only Engine API server modules are initialized in the Binary #63

0xOsiris opened this issue Jan 28, 2025 · 3 comments · Fixed by #69

Comments

@0xOsiris
Copy link
Contributor

0xOsiris commented Jan 28, 2025

The only RPC methods actually initialized in rollup-boost is from the Engine API server here.

I noticed this while testing #61 on a local Devnet.

On main this means eth_sendRawTransaction is not a registered RPC method on the Server.

@0xKitsune
Copy link
Contributor

0xKitsune commented Jan 29, 2025

For visibility, I am currently working on a fix that merges and initializes all RPC modules and will open a PR once I have finished writing additional tests.

@avalonche
Copy link
Collaborator

EthApiServer and EngineApiServer are both implemented for EthEngineApi though, how did you test this?

@0xOsiris
Copy link
Contributor Author

0xOsiris commented Jan 30, 2025

EthApiServer and EngineApiServer are both implemented for EthEngineApi though, how did you test this?

@avalonche You can verify this by simply logging

module.method_names().for_each(|name| {
    info!("Registered Method {}", name);
})

In the binary. The rpc proc macro implements into_rpc on the EthEngineApi 2 times, but it's only pulling from a single implementation (Engine API) when calling into_rpc. The modules need to be merged into a single module. We will have a PR open today that resolves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants