Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Reuse JIT code path for building AOT wheel #791

Open
abcdabcd987 opened this issue Feb 6, 2025 · 0 comments
Open

[Feature] Reuse JIT code path for building AOT wheel #791

abcdabcd987 opened this issue Feb 6, 2025 · 0 comments

Comments

@abcdabcd987
Copy link
Member

Currently we maintain AOT csrc and JIT csrc separately. Since JIT is the priority and AOT is tested less often, AOT falls out of sync with JIT from time to time. This causes lots of issues (e.g., compilation failure, linking failure, missing symbols at runtime, falling back to JIT) and duplicated work must be paid to bring the changes to AOT. This is clearly not sustainable.

On the other hand, we do want to have a wheel that have some common kernels precompiled.

My proposal is: Get rid of AOT csrc. Use JIT code path to generate and compile kernels during wheel build time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant