kola: Enable SELinux as early as possible #487
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
We never really tested SELinux because we enabled it after boot while normally it would be permanently enabled even during (re)boot. We need to enable it via Ignition. Since this won't work with old releases due to policy problems, introduce a flag that the old scripts branches can pass. Note: If tests differ between early and non-early enabling I would rather disable SELinux for those cases and add a comment if and under what future conditions it can be reenabled. The alternative would be to only make them run with the new early mode but this means we reduce test coverage for Stable which is not a good idea.
pothos
force-pushed
the
kai/selinux-boot
branch
from
9bb15ca
to
9dee4e6
Compare
pothos
changed the title
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 2, 2024
This tests flatcar/mantle#487 kola: Enable SELinux as early as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never really tested SELinux because we enabled it after boot while
normally it would be permanently enabled even during (re)boot.
We need to enable it via Ignition. Since this won't work with old
releases due to policy problems, introduce a flag that the old scripts
branches can pass.
Note: If tests differ between early and non-early enabling I would
rather disable SELinux for those cases and add a comment if and under
what future conditions it can be reenabled. The alternative would be to
only make them run with the new early mode but this means we reduce test
coverage for Stable which is not a good idea.
How to use
Testing done
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.