Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS warnings on new settings page #424

Closed
zwass opened this issue Mar 9, 2021 · 3 comments
Closed

JS warnings on new settings page #424

zwass opened this issue Mar 9, 2021 · 3 comments

Comments

@zwass
Copy link
Member

zwass commented Mar 9, 2021

Not sure whether these are indicative of further issues or not:

I get this when I refresh the page on the settings page.

Screen Shot 2021-03-09 at 8 27 56 AM
@zwass zwass added the frontend label Mar 9, 2021
@ghernandez345
Copy link
Contributor

hey yah i've seen them. we are not using the TabPanel so i should look at how to suppress those.

@mikermcneil
Copy link
Member

mikermcneil commented Jun 21, 2021 •
edited
Loading

This is related to the tabs library we're using. Converted it into a planned project for H2. Let's make this issue about getting rid of the JavaScript error-- we don't want any client-side JS errors in Fleet, because they can mask real issues and make debugging more difficult.

@mikermcneil mikermcneil added ~spiffier Improvements to UX or look and feel project and removed idea labels Jun 21, 2021
@mikermcneil mikermcneil added this to the 💻  H2 (2021) milestone Jun 21, 2021
@mikermcneil mikermcneil removed the ~spiffier Improvements to UX or look and feel label Jun 21, 2021
@noahtalerman noahtalerman removed this from the 💻  H2 (2021) milestone Jan 24, 2022
@zwass
Copy link
Member Author

zwass commented Feb 8, 2022

Closing in favor of #937.

@zwass zwass closed this as completed Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zwass @mikermcneil @ghernandez345 @noahtalerman