Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute to this repository #391

Closed
pimvanderheijden opened this issue Jan 9, 2019 · 12 comments
Closed

Contribute to this repository #391

pimvanderheijden opened this issue Jan 9, 2019 · 12 comments

Comments

@pimvanderheijden
Copy link

Hello @florianholzapfel and anyone reading this.

We (ViriCiti) would love to contribute to this project before serious compatibility issues with Mongoose arise.

Any idea about the future of this repository?

Can we be part of it?

Collaboration is highly much preferred over forking...

@Zertz
Copy link
Collaborator

Zertz commented Jan 9, 2019

Hello, thanks for the support! I'm currently at work but I'll invest some time by the weekend.

Do you have any particular issues in mind?

@pimvanderheijden
Copy link
Author

this one for example: #386

Another one is:

It seems that either 1) there is something wrong with Mongoose v5 Model.pre("save", () => {}) hooks or 2) we need better documentation / explanation of the relation between Mongoose hooks and the "pre" and "post" hooks of this project.

@hereischris
Copy link

@Zertz @MidNightP hi there!
any update on the status of this project? we would also be interested in reviving it.

@pimvanderheijden
Copy link
Author

Not that I know of. We're definitely still interested in a revival.

What kind of features / changes were you thinking about?

@hereischris
Copy link

First of all, mongoose 5 support.

@pimvanderheijden
Copy link
Author

sound great

we need help from @Zertz to acheive this

@Zertz
Copy link
Collaborator

Zertz commented Mar 30, 2019

Hey folks, thanks for your interest!

PR's are welcome! Try to keep changes small and non breaking and I'll be able to merge and publish swiftly.

I can give write access to the repo if you're interested in contributing.

@pimvanderheijden
Copy link
Author

Hey Zertz! Thanks for the reply

I would love to contribute, for example by finishing this PR: #386
Do you have any idea what's wrong here?

Or allowing upsert on PUT is also very interesting for us: #392

Mongoose 5 we also find important but I'm not sure yet about the work that needs to be done in that respect

@Zertz
Copy link
Collaborator

Zertz commented Apr 10, 2019

I think we can land those two PR's in the current version and then release v6 with the only breaking change being the Mongoose upgrade.

@wottpal
Copy link

wottpal commented Jul 3, 2019

Sounds great that this project is becoming alive again :) Mongoose 5 support would be so great.

@StoyanStAtanasov
Copy link
Contributor

What is the status? Is this project alive or what? Came here after doing a project with GraphQL - too complex. Wanted something simple. If this project is dead or dying, any alternatives other than GraphQL?

@Zertz
Copy link
Collaborator

Zertz commented Oct 21, 2022

Closing this as we're about to release support for Mongoose 6.

@Zertz Zertz closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants