Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings and errors on compile, mostly Javadoc related #10

Open
lukespragg opened this issue Aug 14, 2014 · 0 comments
Open

Warnings and errors on compile, mostly Javadoc related #10

lukespragg opened this issue Aug 14, 2014 · 0 comments
Labels

Comments

@lukespragg
Copy link
Member

lukespragg commented Aug 14, 2014

flow-networking\src\main\java\com\flowpowered\networking\Codec.java:66: warning: [unchecked] unchecked cast
            return (Codec<M>) codec;
                              ^
  required: Codec<M>
  found:    Codec<CAP#1>
  where M is a type-variable:
    M extends Message declared in method <M>getCodec()
  where CAP#1 is a fresh type-variable:
    CAP#1 extends Message from capture of ?

flow-networking\src\main\java\com\flowpowered\networking\exception\IllegalOpcodeException.java:26: warning: [serial] serializable class IllegalOpcodeException has no definition of serialVersionUID
public class IllegalOpcodeException extends Exception {
       ^
flow-networking\src\main\java\com\flowpowered\networking\service\CodecLookupService.java:48: warning: [rawtypes] found raw type: Codec
    private final ConcurrentMap<Integer, Codec> opcodes;
                                         ^
  missing type arguments for generic class Codec<T>
  where T is a type-variable:
    T extends Message declared in interface Codec

flow-networking\src\main\java\com\flowpowered\networking\service\CodecLookupService.java:49: warning: [rawtypes] found raw type: Codec
    private final Codec[] opcodeTable;
                  ^
  missing type arguments for generic class Codec<T>
  where T is a type-variable:
    T extends Message declared in interface Codec

flow-networking\src\main\java\com\flowpowered\networking\service\CodecLookupService.java:70: warning: [rawtypes] found raw type: Codec
            opcodeTable = new Codec[size];
                              ^
  missing type arguments for generic class Codec<T>
  where T is a type-variable:
    T extends Message declared in interface Codec

flow-networking\src\main\java\com\flowpowered\networking\session\BasicSession.java:79: warning: [rawtypes] found raw type: MessageHandler
        MessageHandler handler = (MessageHandler) protocol.getMessageHandle(mess
ageClass);
        ^
  missing type arguments for generic class MessageHandler<S,T>
  where S,T are type-variables:
    S extends Session declared in interface MessageHandler
    T extends Message declared in interface MessageHandler

flow-networking\src\main\java\com\flowpowered\networking\AsyncableMessage.java:31: warning: no @return
    public boolean isAsync();
                   ^
flow-networking\src\main\java\com\flowpowered\networking\Codec.java:44: error: reference not found
     * Encodes a {@link Message} into a {@link ByteBuffer}.
                                               ^
flow-networking\src\main\java\com\flowpowered\networking\Codec.java:50: warning: no @return
    ByteBuf encode(ByteBuf buf, T message) throws IOException;
            ^
flow-networking\src\main\java\com\flowpowered\networking\NetworkClient.java:66: warning: no description for @param
     * @param <T>
       ^
flow-networking\src\main\java\com\flowpowered\networking\NetworkClient.java:67: warning: no description for @param
     * @param option
       ^
flow-networking\src\main\java\com\flowpowered\networking\NetworkClient.java:68: warning: no description for @param
     * @param value
       ^
flow-networking\src\main\java\com\flowpowered\networking\processor\simple\SimpleMessageProcessor.java:31: error: reference not found
 * Bridge class for passing ByteBufs through byte array read/write processing. This is only only one {@link DividedMessageProcessorPart} and must use a {@link DividedMessageProcessor}
                            ^
flow-networking\src\main\java\com\flowpowered\networking\processor\simple\SimpleMessageProcessor.java:31: error: reference not found
 * Bridge class for passing ByteBufs through byte array read/write processing. This is only only one {@link DividedMessageProcessorPart} and must use a {@link DividedMessageProcessor}
                                                                               ^

flow-networking\src\main\java\com\flowpowered\networking\session\Session.java:45: warning: no @param for <T>
    <T extends Message> void messageReceived(T message);
                             ^
flow-networking\src\main\java\com\flowpowered\networking\session\Session.java:91: warning: no description for @param
     * @param throwable
       ^
flow-networking\src\main\java\com\flowpowered\networking\session\PulsingSession.java:58: warning: no @param for bootstrapProtocol
    public PulsingSession(Channel channel, AbstractProtocol bootstrapProtocol) {

           ^
flow-networking\src\main\java\com\flowpowered\networking\session\Session.java:36: error: self-closing element not allowed
 * <br/>
   ^
flow-networking\src\main\java\com\flowpowered\networking\processor\MessageProcessor.java:30: error: reference not found
 * {@code MessageProcessor} can be used in a {@link PreprocessReplayingDecoder}
or {@link ProcessingEncoder} to define
                                                    ^
flow-networking\src\main\java\com\flowpowered\networking\processor\MessageProcessor.java:30: error: reference not found
 * {@code MessageProcessor} can be used in a {@link PreprocessReplayingDecoder}
or {@link ProcessingEncoder} to define

          ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\keyed\KeyedProtocol.java:76: warning: no @param for key
    protected HandlerLookupService getHandlerLookupService(String key) {
                                   ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\keyed\KeyedProtocol.java:85: warning: no @param for key
    protected CodecLookupService getCodecLookupService(String key) {
                                 ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\AbstractProtocol.java:80: warning: no @param for <T>
    public <T extends Message> Message getWrappedMessage(T dynamicMessage) throws IOException {
                                       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\AbstractProtocol.java:80: warning: no @throws for java.io.IOException
    public <T extends Message> Message getWrappedMessage(T dynamicMessage) throws IOException {
                                       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\keyed\KeyedProtocol.java:49: warning: no description for @param
     * @param name
       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\keyed\KeyedProtocol.java:50: error: no tag name after @
     * @param maxPackets {@see CodecLookupService}
                         ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\keyed\KeyedProtocol.java:60: warning: no description for @param
     * @param name
       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\keyed\KeyedProtocol.java:61: error: no tag name after @
     * @param maxPackets {@see CodecLookupService}
                         ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\keyed\KeyedProtocol.java:62: warning: no description for @param
     * @param logger
       ^
flow-networking\src\main\java\com\flowpowered\networking\service\CodecLookupService.java:90: warning: no @throws for java.lang.reflect.InvocationTargetException
    public <M extends Message, C extends Codec<? super M>> CodecRegistration bind(Class<M> messageClazz, Class<C> codecClazz, Integer opcode) throws InstantiationException, IllegalAccessException, InvocationTargetException {
                                                                             ^
flow-networking\src\main\java\com\flowpowered\networking\service\CodecLookupService.java:57: error: bad use of '>'
     * If the provided size is 0 then a map for the opcode->Codec mapping; otherwise, an array will be used.
                                                           ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\AbstractProtocol.java:46: warning: no description for @param
     * @param name
       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\AbstractProtocol.java:47: error: @param name not found
     * @param maxPackets
              ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\AbstractProtocol.java:47: warning: no description for @param
     * @param maxPackets
       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\AbstractProtocol.java:48: warning: no description for @param
     * @param logger
       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\ProtocolRegistry.java:45: warning: no @param for port
    public void registerProtocol(int port, T protocol) {
                ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\simple\SimpleProtocol.java:46: warning: no description for @param
     * @param name
       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\simple\SimpleProtocol.java:47: error: no tag name after @
     * @param maxPackets {@see CodecLookupService}
                         ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\simple\SimpleProtocol.java:56: warning: no description for @param
     * @param name
       ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\simple\SimpleProtocol.java:57: error: no tag name after @
     * @param maxPackets {@see CodecLookupService}
                         ^
flow-networking\src\main\java\com\flowpowered\networking\protocol\simple\SimpleProtocol.java:58: warning: no description for @param
     * @param logger
       ^
flow-networking\src\main\java\com\flowpowered\networking\exception\UnknownPacketException.java:40: warning: no @param for message
    public UnknownPacketException(String message, int opcode, int length) {
           ^
flow-networking\src\main\java\com\flowpowered\networking\exception\UnknownPacketException.java:40: warning: no @param for length
    public UnknownPacketException(String message, int opcode, int length) {
           ^
flow-networking\src\main\java\com\flowpowered\networking\pipeline\MessageDecoder.java:38: error: reference not found
 * A {@link PreprocessReplayingDecoder} which decodes {@link ByteBuf}s into Common {@link Message}s.
            ^
flow-networking\src\main\java\com\flowpowered\networking\pipeline\MessageHandler.java:40: error: reference not found
 * A {@link SimpleChannelUpstreamHandler} which processes incoming network events.
            ^
flow-networking\src\main\java\com\flowpowered\networking\pipeline\MessageHandler.java:52: warning: no @param for connectionManager
    public MessageHandler(ConnectionManager connectionManager) {
           ^
@lukespragg lukespragg added the bug label Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant