Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling Between Menu and Close Icons #11736

Open
1 task done
zalabhavy opened this issue Feb 23, 2025 · 2 comments · May be fixed by #11737
Open
1 task done

Toggling Between Menu and Close Icons #11736

zalabhavy opened this issue Feb 23, 2025 · 2 comments · May be fixed by #11737
Assignees
@zalabhavy
Labels
e0-minutes Effort: < 60 min infra.design Relates to the design of docs.flutter.dev infra.structure Relates to the tools that create docs.flutter.dev p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.

Comments

@zalabhavy
Copy link
Contributor

Describe the problem

I noticed that the close icon is missing on small screens on this documentation website. I will update the HTML and add CSS in header.css to create an attractive toggle effect. Below is a demo of my idea.

Expected fix

Screen.Recording.2025-02-23.at.8.12.56.PM.mov

On which browser(s) did you experience this issue?

Chrome

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@zalabhavy zalabhavy added the infra.design Relates to the design of docs.flutter.dev label Feb 23, 2025
@zalabhavy
Copy link
Contributor Author

@Sfshaza @parlough I think this will improve the user experience. I have solved it on my local machine, and it works well. 😁

@parlough parlough added infra.structure Relates to the tools that create docs.flutter.dev p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. e0-minutes Effort: < 60 min labels Feb 24, 2025
@parlough
Copy link
Member

Sounds great to me @zalabhavy! Thanks for thinking of this.

I'd be happy to review a PR if you open one with the change.

@zalabhavy zalabhavy linked a pull request Feb 24, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zalabhavy zalabhavy

Labels
e0-minutes Effort: < 60 min infra.design Relates to the design of docs.flutter.dev infra.structure Relates to the tools that create docs.flutter.dev p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Toggling In Close and Menu zalabhavy/website
2 participants
@parlough @zalabhavy