Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC-007: Passwordless authentication for Git repositories for all providers and controllers #4846

Open
8 of 14 tasks
dipti-pai opened this issue Jun 13, 2024 · 5 comments
Labels
area/git Git related issues and pull requests umbrella-issue Umbrella issue for tracking progress of a larger effort

Comments

@dipti-pai
Copy link
Member

dipti-pai commented Jun 13, 2024

This issue tracks the implementation of RFC-007 : Passwordless authentication for Git repositories

WorkItems

Implement pkg changes

Controller changes

CLI changes

Integration tests

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dipti-pai dipti-pai changed the title Implement RFC-007 for all providers Implement RFC-007 for all providers and controllers Jun 13, 2024
@stefanprodan stefanprodan added area/git Git related issues and pull requests umbrella-issue Umbrella issue for tracking progress of a larger effort labels Jun 13, 2024
@Jaykul
Copy link
Contributor

Jaykul commented Jul 9, 2024

When we have issues to "Implement RFC-###" it would be helpful to put the RFC title in the issue title: "Implement RFC-007 Passwordless authentication for Git repositories"

If you want to put something else in, as you did here, we should at least put it in that first line, so instead of "This issue tracks the implementation of RFC-007" ... you'd save most people a click if it said "This issue tracks the implementation of RFC-007 Passwordless authentication for Git repositories"

@stefanprodan stefanprodan pinned this issue Aug 28, 2024
@dipti-pai dipti-pai changed the title Implement RFC-007 for all providers and controllers Implement RFC-007: Passwordless authentication for Git repositories for all providers and controllers Aug 28, 2024
@stefanprodan
Copy link
Member

I have removed CodeCommit as this service has been shutdown by AWS.

@ArKam
Copy link

ArKam commented Oct 25, 2024

Sorry to bother guys, I've just created a request about kinda this topic as I was redirected from the documentation directly to the issue template creation.

But, wouldn't it OIDC/OAuth2 standard implementation belong onto this as a method for GIT authentication against IaC for gitea/gitlab/forgejo/others too?

@qzmiro
Copy link

qzmiro commented Nov 29, 2024

Hello!
The issue states for all controllers but does this include the notification-controller? i'm trying to use the GithubDispatch provider in my company but since it allows only PAT token, it's a bit complicated to negociate with the security team.

@stefanprodan
Copy link
Member

stefanprodan commented Dec 2, 2024

@qzmiro I agree that notification-controller should work with GitHub App auth for commit status updates and workflow dispatch. Can you please open an issue in NC repo for these two?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests umbrella-issue Umbrella issue for tracking progress of a larger effort
Projects
None yet
Development

No branches or pull requests

5 participants