Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No ZED namespace allowed in Yves #3

Open
newLoki opened this issue Feb 20, 2019 · 0 comments
Open

No ZED namespace allowed in Yves #3

newLoki opened this issue Feb 20, 2019 · 0 comments
Assignees
@gengjozsef
Labels
enhancement New feature or request

Comments

@newLoki
Copy link

newLoki commented Feb 20, 2019

Please consider to not use the price calculation helper from Zed (

spryker-google-tagmanager/src/FondOfSpryker/Yves/GoogleTagManager/Business/Model/DataLayer/VariableBuilder.php

Line 41 in 5f8bcd2

protected $priceCalculationHelper;
) but build one for Yves or request Spryker to move the price helper to the Shared namespace as it violates one of the essential architectural rules from spryker to call Zed code from Yves directly (https://github.com/spryker/architecture-sniffer/blob/master/src/Common/LayerAccessRule.php#L35).
@newLoki newLoki changed the title Now ZED namespace allowed in Yves No ZED namespace allowed in Yves Feb 20, 2019
@tillhess tillhess assigned tillhess and gengjozsef and unassigned tillhess Feb 20, 2019
@tillhess tillhess added the enhancement New feature or request label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gengjozsef gengjozsef

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tillhess @newLoki @gengjozsef