Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easter eggs are more fun when they're hidden #3088

Closed
wants to merge 1 commit into from

Conversation

AshlinHarris
Copy link

@AshlinHarris AshlinHarris commented Nov 6, 2024

This pull zeros out motivational_word_probability parameter, which effectively hides the motivational messages by default.

The motivational messages add some levity to the development process and have received positive feedback from the community. On the other hand, at least some developers find them somewhat distracting. The random messages are bold and vivid, which can draw a user's attention unnecessarily. This potential issue can be compounded if the end user is a nondeveloper, since they might not be aware of the context and probably shouldn't be redirected to the Julia discourse home page.

This change would fix #3062

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/AshlinHarris/Pluto.jl", rev="main")
julia> using Pluto

@fonsp fonsp closed this Nov 7, 2024
@fonsp
Copy link
Owner

fonsp commented Nov 7, 2024

Be respectful and positive please!

@fonsp
Copy link
Owner

fonsp commented Nov 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Motivational words for errors" are being displayed for all errors
2 participants