Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely removed remix forge integration #165

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Completely removed remix forge integration #165

merged 2 commits into from
Nov 18, 2024

Conversation

AlemTuzlak
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

If this is a new feature please add a description of what was added and why below:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AlemTuzlak AlemTuzlak marked this pull request as ready for review November 18, 2024 15:24
Copy link

github-actions bot commented Nov 18, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.44% (🎯 80%) 708 / 819
🟢 Statements 86.44% (🎯 80%) 708 / 819
🟢 Functions 71.87% (🎯 70%) 23 / 32
🟢 Branches 83.33% (🎯 75%) 75 / 90
File CoverageNo changed files found.
Generated in workflow #73 for commit 6576489 by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Nov 18, 2024

Open in Stackblitz

yarn add https://pkg.pr.new/forge42dev/Remix-Dev-Tools/[email protected]

commit: 6576489

@AlemTuzlak AlemTuzlak changed the title Potential fix for ws issue Completely removed remix forge integration Nov 18, 2024
@AlemTuzlak AlemTuzlak merged commit 28711a9 into main Nov 18, 2024
6 checks passed
@AlemTuzlak AlemTuzlak deleted the fix-for-socket branch November 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant