paid_via, payment mode switch from v1

[iamareebjamal]

For some reason, when new version was created, a behaviour from legacy site was changed. paid_via, payment_mode were switched with each other. And this is causing inconsistencies in backend and frontend.

• Discuss and standardize the usage of these columns,
• create a migration to switch between the two to make it consistent,
• and fix server and frontend code to use correct fields where approppriate

Current Data:

+----------------+------------+---------+----------------------------------+
| payment_mode   | paid_via   | count   | last_order_date                  |
|----------------+------------+---------+----------------------------------|
| <null>         | transfer   | 5       | 2019-01-28 21:08:22.169331+05:30 |
| <null>         | onsite     | 15      | 2018-12-27 17:51:52.287084+05:30 |
| <null>         | cheque     | 2       | 2018-11-19 21:51:13.081516+05:30 |
| card           | stripe     | 554     | 2019-03-31 12:51:41.664581+05:30 |
| paypal         | paypal     | 90      | 2020-09-25 06:12:21.211695+05:30 |
| stripe         | card       | 45      | 2020-03-04 10:26:29.134881+05:30 |
| <null>         | paypal     | 320     | 2019-04-25 15:55:44.394158+05:30 |
+----------------+------------+---------+----------------------------------+

[sp35]

@iamareebjamal Going by the example it makes sense to see payment_mode as card and paid_via as stripe; standardizing paid_via as the provider and payment_mode as the method.

[sp35]

I see both of them being used interchangeably as well.

open-event-server/app/api/schema/event_invoices.py

Lines 30 to 36 in 2a55a5f

	paid_via = fields.Str(
	validate=validate.OneOf(
	choices=["free", "stripe", "paypal", "transfer", "onsite", "cheque"]
	),
	allow_none=True,
	)
	payment_mode = fields.Str(allow_none=True)

open-event-server/app/api/schema/orders.py

Lines 64 to 81 in 2a55a5f

	payment_mode = fields.Str(
	default="free",
	validate=validate.OneOf(
	choices=[
	"free",
	"stripe",
	"paypal",
	"bank",
	"cheque",
	"onsite",
	"omise",
	"alipay",
	"paytm",
	]
	),
	allow_none=True,
	)
	paid_via = fields.Str(dump_only=True)

[iamareebjamal]

Yes, that makes sense but I'd like to discuss this in meeting once as well. I forgot last time. However, if you want to work on it, you can start because the above reason looks the most logical. If we need to switch, it won't take much time