Wrong calculation of yesterday and today

[hongquan]

Sometimes I made report late, after doing some works in the morning. Scrum Helper then puts my "today morning" works to the yesterday group:

[vedansh-5]

I see, this is happening because in today and yesterday function time is not used, and by default they use 00:00, which is causing this error, let me take this up and add the time variable to this.

[vedansh-5]

@hongquan Was this issue observed before merging of #62 ?

[vedansh-5]

@Preeti9764 Could you skim through the code and see figure out why its happening, I seem to have tried quite a few things but I can't really know for sure because I can't reproduce the issue.

[vedansh-5]

The issue here is not time variables but the way timestamps are supposed to work. As a matter of fact the script works as expected.
The script is supposed to fetch the data from the start of starting date to the end of ending date.
The confusion actually is caused of the headers. As it shows What did I do yesterday? while it really means what I have done from the start of starting date to the end of ending date, which would be what I have done till now if I select the checkboxes of 1/7 days.
We'll soon rollout a feature in #103 of customizing these headers according to user's own will.
Till then we can smartly choose the time based on what we need.
Since the corresponding issue will be solved with #103, PR #66 is no longer needed.
Thanks!

[hongquan]

@vedansh-5

the script works as expected.

No.
When I make report late (like at noon), I want the "today morning" works to be put in the "today" group, but it put them to "yesterday" group. How can it be called "as expected"?

[vedansh-5]

@vedansh-5

the script works as expected.

No. When I make report late (like at noon), I want the "today morning" works to be put in the "today" group, but it put them to "yesterday" group. How can it be called "as expected"?

I understand your concern. Thanks for pointing this out!
Let's discuss a use case to make the picture clearer.

• I'm a user who intends to send a report at noon just like in your case. I check the checkbox for contributions of last one day. The extension fetches the data and puts it under the header of What did I do yesterday?

While this makes no sense, there's an explanation to this.
When we select the last one day checkbox it fetches our activity up till the moment. And puts it inside the header.
Let's see how two people use the extension to create a report.

• The first one uses it at the end of the day or in the middle of the day and wants to show what they have done today. But the extension puts all their "today" work under the "yesterday" header.
• The second user uses it at the start of their day and generates the report, it fetches the data for them correctly and puts it under the "yesterday" header.

The issue here is not in the timestamps or fetching logic of the extension. It's in the headers. They should be changed according to the user's will. For eg: when I fetch "today" work it should be put under the What did I do today? and when I use it to fetch the data for yesterday's work it should be put under the current header.
In #103 this will be implemented.
In this new PR we would add a functionality in which the user can create custom headers and save them to be loaded later according to their usecase.
Thanks!

[hongquan]

The issue here is not in the timestamps or fetching logic of the extension. It's in the headers.

No, the headers are already as my expected. I still just need two groups "yesterday" and "today".

Given that I live in UTC+07 timezone. On 02 Jun, I made a report late, at 11 AM, and before that, I did some work at 9AM.
Here is what I expect:

1. The "yesterday" group:

• List all my works on 01 Jun only, before 02 Jun of UTC+07 timezone.
• Don't list my work which was done at 9AM, 02 Jun.

2. The "today" group:

• List all my works since 02 Jun 00:00.
• It must include the work which I did at 9AM, 02 Jun.

Here is what happens:

1. The "yesterday" group.

• List all my works on 01 Jun, before 02 Jun of UTC+07 timezone.
• List the work which I did at 9AM, 02 Jun (<~~ Not my expectation)

2. The "today" group.

• Empty (<~~ it should not).

[vedansh-5]

Here is what happen:

1. The "yesterday" group.

• List all my works on 01 Jun only, before 02 Jun of UTC+07 timezone.
• List the work which I did at 9AM, 02 Jun (<~~ Not my expectation)

2. The "today" group.

• Empty (<~~ it should not).

I understand the issue Mr. Quan, and a fair point you're raising.
The extension is configured to fetch the data and put it inside the first header which in your case should be What did I do from 1 Jun to 2 Jun. While the extension works correctly your point compels us to add this as an enhancement in the scrum writing logic.
Then the fetched data would be filtered into two headers for use cases similar to yours (when the user wants to display both yesterday and today's data under different headers) in which current day's activity would be put under What did i do Today? / What I plan to do Today?