Replace #[allow()] with #[expect()] (#10131)

* Replace `#[allow()]` with `#[expect()]`

* Remove unfulfilled `#[expect()]` and revert one that can't be changed

* Revert to allow[()] on large enums

* Keep `#[expect()]`` on large enums

* Keep `#[expect()]` on large enums

* Fix all CI

* Fix all CI

* Fix all CI

* Replace #[expect()] with #[allow()]

* Fix CI failure

---------

Co-authored-by: grandizzy <[email protected]>

Author: 0xMushow

crates/anvil/core/src/eth/mod.rs

@@ -36,7 +36,7 @@ pub struct Params<T: Default> {
 /// Represents ethereum JSON-RPC API
 #[derive(Clone, Debug, serde::Deserialize)]
 #[serde(tag = "method", content = "params")]
-#[allow(clippy::large_enum_variant)]
+#[expect(clippy::large_enum_variant)]
 pub enum EthRequest {
     #[serde(rename = "web3_clientVersion", with = "empty_params")]
     Web3ClientVersion(()),

crates/anvil/core/src/eth/serde_helpers.rs

@@ -1,6 +1,5 @@
 //! custom serde helper functions
 
-#[allow(dead_code)]
 pub mod sequence {
     use serde::{
         de::DeserializeOwned, ser::SerializeSeq, Deserialize, Deserializer, Serialize, Serializer,

crates/anvil/core/src/types.rs

@@ -36,8 +36,8 @@ pub struct ReorgOptions {
 }
 
 #[derive(Debug, Clone, Deserialize)]
-#[allow(clippy::large_enum_variant)]
 #[serde(untagged)]
+#[expect(clippy::large_enum_variant)]
 pub enum TransactionData {
     JSON(TransactionRequest),
     Raw(Bytes),

crates/anvil/src/eth/api.rs

@@ -133,7 +133,7 @@ pub struct EthApi {
 
 impl EthApi {
     /// Creates a new instance
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub fn new(
         pool: Arc<Pool>,
         backend: Arc<backend::mem::Backend>,
@@ -2803,7 +2803,7 @@ impl EthApi {
     }
 
     /// Returns the first signer that can sign for the given address
-    #[allow(clippy::borrowed_box)]
+    #[expect(clippy::borrowed_box)]
     pub fn get_signer(&self, address: Address) -> Option<&Box<dyn Signer>> {
         self.signers.iter().find(|signer| signer.is_signer_for(address))
     }

crates/anvil/src/eth/backend/mem/mod.rs

@@ -213,7 +213,7 @@ pub struct Backend {
 
 impl Backend {
     /// Initialises the balance of the given accounts
-    #[allow(clippy::too_many_arguments)]
+    #[expect(clippy::too_many_arguments)]
     pub async fn with_genesis(
         db: Arc<AsyncRwLock<Box<dyn Db>>>,
         env: Arc<RwLock<EnvWithHandlerCfg>>,
@@ -1022,7 +1022,7 @@ impl Backend {
     }
 
     /// Creates an EVM instance with optionally injected precompiles.
-    #[allow(clippy::type_complexity)]
+    #[expect(clippy::type_complexity)]
     fn new_evm_with_inspector_ref<'i, 'db>(
         &self,
         db: &'db dyn DatabaseRef<Error = DatabaseError>,
@@ -2876,7 +2876,6 @@ impl TransactionValidator for Backend {
 }
 
 /// Creates a `AnyRpcTransaction` as it's expected for the `eth` RPC api from storage data
-#[allow(clippy::too_many_arguments)]
 pub fn transaction_build(
     tx_hash: Option<B256>,
     eth_transaction: MaybeImpersonatedTransaction,

crates/anvil/src/eth/backend/mem/storage.rs

@@ -350,7 +350,6 @@ impl BlockchainStorage {
         self.best_number = U64::from(block_number);
     }
 
-    #[allow(unused)]
     pub fn empty() -> Self {
         Self {
             blocks: Default::default(),

crates/anvil/src/service.rs

@@ -94,7 +94,6 @@ impl Future for NodeService {
             let filters = pin.filters.clone();
 
             // evict filters that timed out
-            #[allow(clippy::redundant_async_block)]
             tokio::task::spawn(async move { filters.evict().await });
         }
 

crates/anvil/tests/it/eip4844.rs

@@ -205,7 +205,7 @@ async fn can_check_blob_fields_on_genesis() {
     assert_eq!(block.header.excess_blob_gas, Some(0));
 }
 
-#[allow(clippy::disallowed_macros)]
+#[expect(clippy::disallowed_macros)]
 #[tokio::test(flavor = "multi_thread")]
 async fn can_correctly_estimate_blob_gas_with_recommended_fillers() {
     let node_config = NodeConfig::test().with_hardfork(Some(EthereumHardfork::Cancun.into()));
@@ -248,7 +248,7 @@ async fn can_correctly_estimate_blob_gas_with_recommended_fillers() {
     );
 }
 
-#[allow(clippy::disallowed_macros)]
+#[expect(clippy::disallowed_macros)]
 #[tokio::test(flavor = "multi_thread")]
 async fn can_correctly_estimate_blob_gas_with_recommended_fillers_with_signer() {
     let node_config = NodeConfig::test().with_hardfork(Some(EthereumHardfork::Cancun.into()));

crates/anvil/tests/it/fork.rs

@@ -28,15 +28,15 @@ const DEAD_BALANCE_AT_BLOCK_NUMBER: u128 = 12_556_069_338_441_120_059_867u128;
 const BLOCK_TIMESTAMP: u64 = 1_650_274_250u64;
 
 /// Represents an anvil fork of an anvil node
-#[allow(unused)]
+#[expect(unused)]
 pub struct LocalFork {
     origin_api: EthApi,
     origin_handle: NodeHandle,
     fork_api: EthApi,
     fork_handle: NodeHandle,
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 impl LocalFork {
     /// Spawns two nodes with the test config
     pub async fn new() -> Self {

crates/anvil/tests/it/main.rs

@@ -22,7 +22,6 @@ mod txpool;
 pub mod utils;
 mod wsapi;
 
-#[allow(unused)]
 pub(crate) fn init_tracing() {
     let _ = tracing_subscriber::FmtSubscriber::builder()
         .with_env_filter(tracing_subscriber::EnvFilter::from_default_env())

crates/anvil/tests/it/pubsub.rs

@@ -247,7 +247,7 @@ async fn test_subscriptions() {
     assert_eq!(blocks, vec![1, 2, 3])
 }
 
-#[allow(clippy::disallowed_macros)]
+#[expect(clippy::disallowed_macros)]
 #[tokio::test(flavor = "multi_thread")]
 async fn test_sub_new_heads_fast() {
     let (api, handle) = spawn(NodeConfig::test()).await;

crates/cast/src/cmd/create2.rs

@@ -89,7 +89,6 @@ pub struct Create2Args {
     no_random: bool,
 }
 
-#[allow(dead_code)]
 pub struct Create2Output {
     pub address: Address,
     pub salt: B256,
@@ -227,7 +226,7 @@ impl Create2Args {
                     }
 
                     // Calculate the `CREATE2` address.
-                    #[allow(clippy::needless_borrows_for_generic_args)]
+                    #[expect(clippy::needless_borrows_for_generic_args)]
                     let addr = deployer.create2(&salt.0, &init_code_hash);
 
                     // Check if the regex matches the calculated address' checksum.

crates/cast/src/cmd/send.rs

@@ -85,7 +85,7 @@ pub enum SendTxSubcommands {
 }
 
 impl SendTxArgs {
-    #[allow(unknown_lints, dependency_on_unit_never_type_fallback)]
+    #[expect(dependency_on_unit_never_type_fallback)]
     pub async fn run(self) -> eyre::Result<()> {
         let Self {
             eth,

crates/cast/src/rlp_converter.rs

@@ -109,7 +109,7 @@ mod test {
     }
 
     #[test]
-    #[allow(clippy::disallowed_macros)]
+    #[expect(clippy::disallowed_macros)]
     fn encode_decode_test() -> alloy_rlp::Result<()> {
         let parameters = vec![
             (1, b"\xc0".to_vec(), Item::Array(vec![])),
@@ -151,7 +151,7 @@ mod test {
     }
 
     #[test]
-    #[allow(clippy::disallowed_macros)]
+    #[expect(clippy::disallowed_macros)]
     fn deserialize_from_str_test_hex() -> JsonResult<()> {
         let parameters = vec![
             (1, "[\"\"]", Item::Array(vec![Item::Data(vec![])])),

crates/cast/src/tx.rs

@@ -25,7 +25,7 @@ use serde_json::value::RawValue;
 use std::fmt::Write;
 
 /// Different sender kinds used by [`CastTxBuilder`].
-#[allow(clippy::large_enum_variant)]
+#[expect(clippy::large_enum_variant)]
 pub enum SenderKind<'a> {
     /// An address without signer. Used for read-only calls and transactions sent through unlocked
     /// accounts.

crates/cheatcodes/spec/src/lib.rs

@@ -107,7 +107,7 @@ impl Cheatcodes<'static> {
 }
 
 #[cfg(test)]
-#[allow(clippy::disallowed_macros)]
+#[expect(clippy::disallowed_macros)]
 mod tests {
     use super::*;
     use std::{fs, path::Path};

crates/cheatcodes/src/script.rs

@@ -196,7 +196,7 @@ pub struct Wallets {
 }
 
 impl Wallets {
-    #[allow(missing_docs)]
+    #[expect(missing_docs)]
     pub fn new(multi_wallet: MultiWallet, provided_sender: Option<Address>) -> Self {
         Self { inner: Arc::new(Mutex::new(WalletsInner { multi_wallet, provided_sender })) }
     }

crates/cheatcodes/src/test/expect.rs

@@ -672,7 +672,7 @@ impl RevertParameters for ExpectedRevert {
 ///   `vm.expectCall(address(0xc4f3), abi.encodeWithSelector(0xd34db33f))` will expect the call to
 ///   address(0xc4f3) and selector `0xd34db33f` to be made at least once. If the amount of calls is
 ///   0, the test will fail. If the call is made more than once, the test will pass.
-#[allow(clippy::too_many_arguments)] // It is what it is
+#[expect(clippy::too_many_arguments)] // It is what it is
 fn expect_call(
     state: &mut Cheatcodes,
     target: &Address,
@@ -1010,7 +1010,7 @@ fn checks_topics_and_data(checks: [bool; 5], expected: &RawLog, log: &RawLog) ->
 
 fn expect_safe_memory(state: &mut Cheatcodes, start: u64, end: u64, depth: u64) -> Result {
     ensure!(start < end, "memory range start ({start}) is greater than end ({end})");
-    #[allow(clippy::single_range_in_vec_init)] // Wanted behaviour
+    #[expect(clippy::single_range_in_vec_init)] // Wanted behaviour
     let offsets = state.allowed_mem_writes.entry(depth).or_insert_with(|| vec![0..0x60]);
     offsets.push(start..end);
     Ok(Default::default())

crates/chisel/src/executor.rs

@@ -801,7 +801,7 @@ impl Type {
         }
 
         // Type members, like array, bytes etc
-        #[allow(clippy::single_match)]
+        #[expect(clippy::single_match)]
         match &self {
             Self::Access(inner, access) => {
                 if let Some(ty) = inner.as_ref().clone().try_as_ethabi(None) {
@@ -1286,7 +1286,6 @@ fn func_members(func: &pt::FunctionDefinition, custom_type: &[String]) -> Option
 /// Whether execution should continue after inspecting this expression
 #[inline]
 fn should_continue(expr: &pt::Expression) -> bool {
-    #[allow(clippy::match_like_matches_macro)]
     match expr {
         // assignments
         pt::Expression::PreDecrement(_, _) |       // --<inner>

crates/chisel/src/solidity_helper.rs

@@ -241,7 +241,7 @@ impl Hinter for SolidityHelper {
 
 impl Helper for SolidityHelper {}
 
-#[allow(non_upper_case_globals)]
+#[expect(non_upper_case_globals)]
 #[deny(unreachable_patterns)]
 fn token_style(token: &Token) -> Style {
     use solar_parse::{

crates/cli/src/utils/mod.rs

@@ -376,7 +376,7 @@ impl<'a> Git<'a> {
         self.cmd().arg("init").exec().map(drop)
     }
 
-    #[allow(clippy::should_implement_trait)] // this is not std::ops::Add clippy
+    #[expect(clippy::should_implement_trait)] // this is not std::ops::Add clippy
     pub fn add<I, S>(self, paths: I) -> Result<()>
     where
         I: IntoIterator<Item = S>,

crates/common/build.rs

@@ -3,7 +3,7 @@ use std::{env, error::Error};
 use chrono::DateTime;
 use vergen::EmitBuilder;
 
-#[allow(clippy::disallowed_macros)]
+#[expect(clippy::disallowed_macros)]
 fn main() -> Result<(), Box<dyn Error>> {
     // Re-run the build script if the build script itself changes or if the
     // environment variables change.

crates/common/fmt/src/console.rs

@@ -453,7 +453,7 @@ mod tests {
         p_3: U256,
     }
 
-    #[allow(unused)]
+    #[expect(unused)]
     #[derive(Clone, Debug, ConsoleFmt)]
     enum Logs {
         Log1(Log1),

crates/common/fmt/src/ui.rs

@@ -781,7 +781,7 @@ impl<T: UIfmt> UIfmt for WithOtherFields<T> {
 /// Various numerical ethereum types used for pretty printing
 #[derive(Clone, Debug, Deserialize)]
 #[serde(untagged)]
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 pub enum EthValue {
     U64(U64),
     U256(U256),

crates/common/src/compile.rs

@@ -548,7 +548,7 @@ pub fn etherscan_project(
 
 /// Configures the reporter and runs the given closure.
 pub fn with_compilation_reporter<O>(quiet: bool, f: impl FnOnce() -> O) -> O {
-    #[allow(clippy::collapsible_else_if)]
+    #[expect(clippy::collapsible_else_if)]
     let reporter = if quiet || shell::is_json() {
         Report::new(NoReporter::default())
     } else {

crates/common/src/contracts.rs

@@ -28,7 +28,7 @@ const CALL_PROTECTION_BYTECODE_PREFIX: [u8; 21] =
     hex!("730000000000000000000000000000000000000000");
 
 /// Subset of [CompactBytecode] excluding sourcemaps.
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 #[derive(Debug, Clone)]
 pub struct BytecodeData {
     pub object: Option<BytecodeObject>,

crates/common/src/errors/fs.rs

@@ -3,13 +3,13 @@ use std::{
     path::{Path, PathBuf},
 };
 
-#[allow(unused_imports)]
+#[expect(unused_imports)]
 use std::fs::{self, File};
 
 /// Various error variants for `fs` operations that serve as an addition to the io::Error which
 /// does not provide any information about the path.
 #[derive(Debug, thiserror::Error)]
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 pub enum FsPathError {
     /// Provides additional path context for [`fs::write`].
     #[error("failed to write to {path:?}: {source}")]

crates/common/src/evm.rs

@@ -280,7 +280,6 @@ impl EvmArgs {
 
 /// We have to serialize chain IDs and not names because when extracting an EVM `Env`, it expects
 /// `chain_id` to be `u64`.
-#[allow(clippy::trivially_copy_pass_by_ref)]
 fn id<S: serde::Serializer>(chain: &Option<Chain>, s: S) -> Result<S::Ok, S::Error> {
     if let Some(chain) = chain {
         s.serialize_u64(chain.id())

crates/common/src/lib.rs

@@ -5,7 +5,7 @@
 #![cfg_attr(not(test), warn(unused_crate_dependencies))]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
-#[allow(unused_extern_crates)] // Used by `ConsoleFmt`.
+#[expect(unused_extern_crates)] // Used by `ConsoleFmt`.
 extern crate self as foundry_common;
 
 #[macro_use]

crates/common/src/term.rs

@@ -45,16 +45,15 @@ impl TermSettings {
     }
 }
 
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 pub struct Spinner {
     indicator: &'static [&'static str],
     no_progress: bool,
     message: String,
     idx: usize,
 }
 
-#[allow(unused)]
-#[allow(missing_docs)]
+#[expect(missing_docs)]
 impl Spinner {
     pub fn new(msg: impl Into<String>) -> Self {
         Self::with_indicator(SPINNERS[0], msg)

crates/config/src/fix.rs

@@ -69,7 +69,7 @@ impl std::error::Error for InsertProfileError {}
 impl TomlFile {
     /// Insert a name as `[profile.name]`. Creating the `[profile]` table where necessary and
     /// throwing an error if there exists a conflict
-    #[allow(clippy::result_large_err)]
+    #[expect(clippy::result_large_err)]
     fn insert_profile(
         &mut self,
         profile_str: &str,

crates/config/src/lib.rs

@@ -4578,7 +4578,7 @@ mod tests {
     }
 
     // a test to print the config, mainly used to update the example config in the README
-    #[allow(clippy::disallowed_macros)]
+    #[expect(clippy::disallowed_macros)]
     #[test]
     #[ignore]
     fn print_config() {
@@ -4604,7 +4604,6 @@ mod tests {
     }
 
     #[test]
-    #[allow(unknown_lints, non_local_definitions)]
     fn can_use_impl_figment_macro() {
         #[derive(Default, Serialize)]
         struct MyArgs {

crates/debugger/src/tui/mod.rs

@@ -100,7 +100,7 @@ impl<'a> TUI<'a> {
 }
 
 // TODO: Update once on 1.82
-#[allow(deprecated)]
+#[expect(deprecated)]
 type PanicHandler = Box<dyn Fn(&std::panic::PanicInfo<'_>) + 'static + Sync + Send>;
 
 /// Handles terminal state.