Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect TransactionOpts in cast call --trace #9391

Open
publicqi opened this issue Nov 23, 2024 · 5 comments
Open

Respect TransactionOpts in cast call --trace #9391

publicqi opened this issue Nov 23, 2024 · 5 comments
Assignees
@tnv1
Labels
C-cast Command: cast good first issue Good for newcomers T-feature Type: feature

Comments

@publicqi
Copy link
Contributor

Component

Cast

Describe the feature you would like

Currently cast call has "Transaction options", which specifies options like gas limit, gas price, etc. However they are not used during simulation with --trace. This is a discussion whether they should also be used.

Additional context

No response
@publicqi publicqi added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Nov 23, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Nov 23, 2024
@publicqi
Copy link
Contributor Author

Implementing is easy, just modifying fields inside get_fork_material

@zerosnacks zerosnacks added C-cast Command: cast good first issue Good for newcomers and removed T-needs-triage Type: this issue needs to be labelled labels Nov 27, 2024
@tnv1
Copy link

tnv1 commented Nov 29, 2024

Hi @publicqi , can i take this issue?. Thanks

@publicqi
Copy link
Contributor Author

Sure go ahead. Thanks

@zerosnacks
Copy link
Member

Thanks @tnv1, assigned to you - let me know if you have any questions

@tnv1
Copy link

tnv1 commented Nov 29, 2024

Thanks @zerosnacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tnv1 tnv1

Labels
C-cast Command: cast good first issue Good for newcomers T-feature Type: feature
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@publicqi @zerosnacks @tnv1