Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: derive block gas limit from RPC to prevent erroneous filling of block during simulation #9752

Open
zerosnacks opened this issue Jan 24, 2025 · 0 comments · May be fixed by #9753
Open

bug: derive block gas limit from RPC to prevent erroneous filling of block during simulation #9752

zerosnacks opened this issue Jan 24, 2025 · 0 comments · May be fixed by #9753
Assignees
@zerosnacks
Labels
C-anvil Command: anvil C-forge Command: forge T-bug Type: bug T-to-investigate Type: to investigate

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Jan 24, 2025 •
edited
Loading

Component

Forge, Anvil

Describe the feature you would like

Related: #9723 / #9723 (comment)

It appears we currently do not estimate / update the gas limit specified by the RPC during simulation which can result in a situation where the filler puts too many transactions into a block during simulation before rolling over to the next

Anvil also does not appear to pick up the gas limit when forking, always defaulting to 30000000. This does not appear to have a clear effect however but should also be fixed.

The expected behavior should be that forge script correctly listens to the gas limit indicated by the RPC (Anvil) and Anvil should correctly set its gas limit based on the fork.

Additional context

No response
@zerosnacks zerosnacks added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Jan 24, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jan 24, 2025
@zerosnacks zerosnacks mentioned this issue Jan 24, 2025
Closed
@zerosnacks zerosnacks changed the title feat: improve deriving block gas limit from RPC during simulation to prevent erroneous filling feat: improve deriving block gas limit from RPC during simulation to prevent erroneous filling of block during simulation Jan 24, 2025
@zerosnacks zerosnacks changed the title feat: improve deriving block gas limit from RPC during simulation to prevent erroneous filling of block during simulation feat: improve deriving block gas limit from RPC to prevent erroneous filling of block during simulation Jan 24, 2025
@zerosnacks zerosnacks added C-forge Command: forge C-anvil Command: anvil and removed T-needs-triage Type: this issue needs to be labelled labels Jan 24, 2025
@zerosnacks zerosnacks mentioned this issue Jan 24, 2025
Open
2 tasks
@zerosnacks zerosnacks changed the title feat: improve deriving block gas limit from RPC to prevent erroneous filling of block during simulation bug: deriving block gas limit from RPC to prevent erroneous filling of block during simulation Jan 24, 2025
@zerosnacks zerosnacks added T-bug Type: bug and removed T-feature Type: feature labels Jan 24, 2025
@zerosnacks zerosnacks changed the title bug: deriving block gas limit from RPC to prevent erroneous filling of block during simulation bug: derive block gas limit from RPC to prevent erroneous filling of block during simulation Jan 24, 2025
@zerosnacks zerosnacks added the T-to-investigate Type: to investigate label Jan 24, 2025
@zerosnacks zerosnacks self-assigned this Jan 24, 2025
This was referenced Jan 24, 2025
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerosnacks zerosnacks

Labels
C-anvil Command: anvil C-forge Command: forge T-bug Type: bug T-to-investigate Type: to investigate
Projects
Foundry
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: derive block gas limit from rpc for forge script and anvil when forking foundry-rs/foundry
1 participant
@zerosnacks