perf(coverage): improve HitMap merging and internal repr #9456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mattsse
approved these changes
Dec 2, 2024
wow, just hitmaps |
|
Yeah turns out that optimizing a function that's called 2 billion times might have a lot of impact 👍 |
|
asked superform to report back new coverage time, would be interesting to see, starting ref 1h15m |
|
Seeing a huge improvement Previously this was taking +30m and often times killed due to OOM issues Memory fairly stable on my local as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u32andHashMaps instead ofusize/u64andBTreeMapHitMaps::mergeLots of time spent in
mergefor inserting in the right order, but the order was never checked (consistent_bytecodeis unused andHitMap::mergereturnedResult, presumably this was removed at a certain point)forge coverageon solmate from 29s to 16s