Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typesafe contract declare #1531

Open
Arcticae opened this issue Jan 15, 2024 · 1 comment
Open

Typesafe contract declare #1531

Arcticae opened this issue Jan 15, 2024 · 1 comment

Comments

@Arcticae
Copy link
Contributor

Arcticae commented Jan 15, 2024

We should consider native name providing solutions with declare, like providing the full path to the contract module, and possibly referring to a generated constant (like a NAME for example).

This task should result in a POC if possible

EDIT: We should wait for scarb plugins in order to implement this cleanly (we need class hashes to match with the real ones)
Also blocked by the fact that the constant is declared with cfg(test) so in tests it wouldn't be possible to use the contract from deps

@Arcticae
Copy link
Contributor Author

Arcticae commented Feb 2, 2024

Artifacts with module info was merged
software-mansion/scarb#1082

@Arcticae Arcticae self-assigned this Feb 5, 2024
@Arcticae Arcticae moved this from TODO to Backlog in Starknet foundry Feb 20, 2024
@Arcticae Arcticae removed their assignment Feb 20, 2024
@Arcticae Arcticae added this to the Plugins inegration milestone Mar 5, 2024
@Arcticae Arcticae moved this from Backlog to Triage in Starknet foundry May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

1 participant