-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for JMS 1.1? #30
Comments
@AL333Z I started looking at adding a Provider for Amazon SQS. Unfortunately SQS only supports JMS 1.1, whilst jms4s requires JMS 2.0. From reading the issues and PRs against amazon-sqs-java-messaging-lib it does not look like Amazon plans to provide JMS 2 support anytime soon :-( I also concluded that "JMS 2 looks to be retro compatible with JMS 1.1". I read here that JMSContext seems to be a convenience:
I wonder if it would be possible to somehow abstract JMSContext below JMS 1.1 and JMS 2.0 specific implementations, so that jms4s could work with either API depending on what is provided on the classpath. Is there any interest from yourself or any of the other project maintainers to see something like this happen? Unfortunately I need something urgently to work with SQS. I am happy to provide PRs etc, but I would like to know if there is any interest in reviewing and merging such changes? |
Hi @adamretter, Summoning @faustin0 (the remaining maintainer that's still around, I guess). |
@AL333Z Thanks that is interesting but ideally we wanted to stick with JMS so that we can change provider if necessary, at present we are uncertain if SQS will work out for us. Likewise, using a different provider than AmazonSQS is useful for our integration tests.
Does this mean that this project should now be considered unmaintained/abandoned? |
I have started prototyping a JMS 1.1 approach here - https://github.com/evolvedbinary/jms4s/tree/aws-sqs |
Currently, we're only targetting JMS 2 since the API is exposing features that are only available starting from JMS 2 (e.g. publish with delay). Also, internals now depends on
JMSContext
, which is available from JMS 2.The only reason to support JMS 1.1 is to give support to additional providers which are currently only targeting JMS 1.1:
Now, if I need to use a lib for interacting with RabbitMQ I'd just use a lib just like fs2-rabbit, so I'm not sure what to do here.
Considerations:
The text was updated successfully, but these errors were encountered: