Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD Overlay "START"-Button does not work in Safari #390

Open
timephy opened this issue Jul 1, 2023 · 3 comments
Open

OSD Overlay "START"-Button does not work in Safari #390

timephy opened this issue Jul 1, 2023 · 3 comments
Labels

Comments

@timephy
Copy link

timephy commented Jul 1, 2023

Device

Goggles V2

Operating System (Including version)

macOS Ventura 13.4.1

Browser

Safari

Trace ID (bottom left of the configurator screen)

c92ec69b-596e-4e08-b7ab-ab272b690886

Describe the issue

Hi, title says it all.

UI-wise nothing happens, but this error is logged to console:
Unhandled Promise Rejection: TypeError: undefined is not a function (near '...window.showSaveFilePicker...')

On Chrome on the other hand everything works (same machine, same video, same fonts).

Here is a screenshot:
image

@rekunkel
Copy link

rekunkel commented Jul 9, 2023

I also have the same issue. Does this only work in Chrome?

@FinalFrag
Copy link
Contributor

This error is caused by our use of the showSaveFilePicker function. So currently it only works in Chrome 86+, Edge 86+, Opera 72+ (source)

We'll have to look into another way to save the file.

@stylesuxx
Copy link
Collaborator

We could fall back to the "oldskool" method of saving the file if showSavFilePicker method is undefined. I implemented it like that in another project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants