You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is just a suggestion and still only a thought in my head.
Based on my understanding, mylar-meteor-changes is responsible for patching a few internal Meteor packages, the most important one probably being ddp, and the patches must be updated accordingly when a new Meteor version comes out.
In order to make this process more maintainable, I was thinking maybe one could do the following:
Create a Meteor package called mylar:ddp. Make this package a git subtree of the folder packages/ddp from the official Meteor repo
Patch mylar-related changes to this package, and publish it to Github/Atmosphere
When a new official Meteor version comes out, update the subtree with git merge -s subtree
If there are conflicts as a result of Meteor change, resolve manually
Commit and publish a new version of mylar:ddp
One can also apply the same process to accounts-base and any other packages that Mylar needs a patch for.
I think the benefit for this approach is that it's likely that the patch will automatically merge with new versions of official dpp package. This also makes the mylar-related changes more visible.
The text was updated successfully, but these errors were encountered:
settinghead
changed the title
Suggestion: create package forks off official Meteor repo with git subtree instead of mylar-meteor-changes
Suggestion: create package forks off official Meteor repo with git subtree
Jan 9, 2015
This is just a suggestion and still only a thought in my head.
Based on my understanding, mylar-meteor-changes is responsible for patching a few internal Meteor packages, the most important one probably being
ddp
, and the patches must be updated accordingly when a new Meteor version comes out.In order to make this process more maintainable, I was thinking maybe one could do the following:
mylar:ddp
. Make this package a git subtree of the folderpackages/ddp
from the official Meteor repogit merge -s subtree
mylar:ddp
One can also apply the same process to
accounts-base
and any other packages that Mylar needs a patch for.I think the benefit for this approach is that it's likely that the patch will automatically merge with new versions of official dpp package. This also makes the mylar-related changes more visible.
The text was updated successfully, but these errors were encountered: