Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: create package forks off official Meteor repo with git subtree #6

Open
settinghead opened this issue Jan 9, 2015 · 0 comments

Comments

@settinghead
Copy link

This is just a suggestion and still only a thought in my head.

Based on my understanding, mylar-meteor-changes is responsible for patching a few internal Meteor packages, the most important one probably being ddp, and the patches must be updated accordingly when a new Meteor version comes out.

In order to make this process more maintainable, I was thinking maybe one could do the following:

  1. Create a Meteor package called mylar:ddp. Make this package a git subtree of the folder packages/ddp from the official Meteor repo
  2. Patch mylar-related changes to this package, and publish it to Github/Atmosphere
  3. When a new official Meteor version comes out, update the subtree with git merge -s subtree
  4. If there are conflicts as a result of Meteor change, resolve manually
  5. Commit and publish a new version of mylar:ddp

One can also apply the same process to accounts-base and any other packages that Mylar needs a patch for.

I think the benefit for this approach is that it's likely that the patch will automatically merge with new versions of official dpp package. This also makes the mylar-related changes more visible.

@settinghead settinghead changed the title Suggestion: create package forks off official Meteor repo with git subtree instead of mylar-meteor-changes Suggestion: create package forks off official Meteor repo with git subtree Jan 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant