Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default apache logrotate config #304

Open
dolanjs opened this issue Feb 12, 2014 · 7 comments · May be fixed by #3714
Open

Change default apache logrotate config #304

dolanjs opened this issue Feb 12, 2014 · 7 comments · May be fixed by #3714
Labels
help wanted Issues we would definitely appreciate volunteer help with ops/deployment

Comments

@dolanjs
Copy link
Contributor

dolanjs commented Feb 12, 2014

Change default apache logrotate to rotate every day and only retain 1 day. This should give enough time for any personnel to get on site for organizations that may opt not to enable ssh.
Since sensitive information could be in error messages the logs should be securely deleted.

@garrettr
Copy link
Contributor

What is the current logrotate interval? We only store Apache logs for the Document Interface anyway, so this is not relevant to minimizing metadata about source behavior. If anything, given our current turnaround on support tickets, 1 day of retention is insufficient and would hamstring us in our efforts to do remote troubleshooting using the logs.

I propose we move this off the 0.4 milestone and revisit at a later date, or close this entirely.

@conorsch
Copy link
Contributor

@garrettr The apache logs are currently set to 52 weekly rotations, meaning compressed logs will remain on disk for approximately one year. Since we don't log the Source Interface, that logging only applies to the Journalist Interface—however, the Journalist Interface logging is currently broken (#1606), so right now zero useful information exists on-disk about Journalist behavior.

@psivesely
Copy link
Contributor

I think persisting logs for 2 weeks would be a reasonable first step. Ideally, we'd be able to reduce this further, but that will require some combination of better support turnaround, and implementation of the opt-in log reporting we've discussed.

@redshiftzero redshiftzero removed this from the 0.4 milestone Mar 15, 2017
@heartsucker
Copy link
Contributor

@redshiftzero Hackathon candidate.

@redshiftzero
Copy link
Contributor

A day is certainly too short, but a month or two is reasonable.

@redshiftzero redshiftzero added the help wanted Issues we would definitely appreciate volunteer help with label Aug 19, 2017
@conorsch
Copy link
Contributor

Agreed with @redshiftzero: let's set the new default logrotate value to 1-2 months. Once the change is made in the Ansible config logic, a playbook run (via ./securedrop-admin install) will be required to enforce the change. Future new installs will receive the updated value automatically.

As stated above, the logrotate functionality is only relevant for the Journalist Interface (previously called the "Document Interface"; see #1384), as the Source Interface does not log visitor interactions in production.

@conorsch conorsch added this to the Product Backlog milestone Feb 21, 2018
@starchy starchy linked a pull request Jun 10, 2019 that will close this issue
5 tasks
@zenmonkeykstop
Copy link
Contributor

Keeping, the existing PR would need to be updated to cover existing instances without a playbook run, but the change is still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues we would definitely appreciate volunteer help with ops/deployment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants