Increase strictness phpstan.

Author: tannguyen04

composer.json

@@ -45,6 +45,7 @@
         "phpstan/extension-installer": "^1.3",
         "phpstan/phpstan": "^1.10",
         "phpstan/phpstan-deprecation-rules": "^1.1",
+        "phpstan/phpstan-strict-rules": "^1.5",
         "phpunit/phpunit": "^9.6",
         "squizlabs/php_codesniffer": "^3.7"
     },

composer.lock

@@ -1,5 +1,5 @@
 parameters:
-    level: 9
+    level: max
     paths:
         - web/modules/custom
         - web/themes/custom

phpstan.neon

@@ -27,7 +27,7 @@ class HomePageController extends ControllerBase {
    */
   public function redirectThatSauce(string $node_uuid) {
     $nodes = $this->entityTypeManager()->getStorage('node')->loadByProperties(['uuid' => $node_uuid]);
-    if (!count($nodes)) {
+    if (count($nodes) === 0) {
       throw new \Exception('Node route UUID doesn\'t appear to match any nodes: ' . $node_uuid);
     }
     $redirect_url = Url::fromRoute('entity.node.canonical', ['node' => reset($nodes)->id()]);

web/modules/custom/fs/src/Controller/HomePageController.php

@@ -13,7 +13,7 @@ function fs_test_requirements(string $phase): array {
   if ($phase === 'install') {
     $error = t('FS Test module can not be installed on production and config is excluded in "config_exclude_modules" setting in settings.php');
 
-    if (getenv('PLATFORM_ENVIRONMENT_TYPE') && getenv('PLATFORM_ENVIRONMENT_TYPE') == 'production') {
+    if (getenv('PLATFORM_ENVIRONMENT_TYPE') === 'production') {
       if (php_sapi_name() == 'cli') {
         // Prevent user from bypassing with Drush.
         throw new \Exception($error);

web/modules/custom/fs_test/fs_test.install

@@ -46,12 +46,12 @@ function fstheme_preprocess_page(array &$vars): void {
  */
 function fstheme_preprocess_region(array &$vars): void {
   try {
-    $variables['is_front'] = \Drupal::service('path.matcher')->isFrontPage();
+    $vars['is_front'] = \Drupal::service('path.matcher')->isFrontPage();
   }
   catch (Exception $e) {
-    $variables['is_front'] = FALSE;
+    $vars['is_front'] = FALSE;
   }
-  $variables['#cache']['contexts'][] = 'url.path';
+  $vars['#cache']['contexts'][] = 'url.path';
 }
 
 /**