Skip to content

Get rid of TODOs #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fs-c opened this issue Jun 28, 2020 · 1 comment
Open

Get rid of TODOs #58

fs-c opened this issue Jun 28, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@fs-c
Copy link
Owner

fs-c commented Jun 28, 2020

Occasionally I add code that I know will have to be rewritten sometime soon (tm). I'm opening this issue to

  • keep track of these instances, since I don't always add a TODO note in the relevant place
  • keep a list of existing TODOs that I can work my way down of
$ git grep "TODO"
src/config.h:   // TODO: None of the text breaking functions handle newlines.
src/config.h:   // TODO: This is ugly and prone to bugs.
src/config.h:   // TODO: This should be more general.
src/osu/osu.cpp:        // TODO: Run this in parallel.
src/osu/osu.cpp:        // TODO: This pile of shit is copied pretty much straight from maniac 0.x and needs to
src/osu/osu.cpp:// TODO: Break up into smaller functions, this is ugly as all hell.
src/osu/osu.h:  // TODO: Generic pointers are bad in the long run.
src/osu/osu.h:  // TODO: Look into KEYEVENTF_SCANCODE (see esp. KEYBDINPUT remarks section).
src/osu/osu.h:  // TODO: Magic numbers are a bad idea.
src/process/process.h:          // TODO: Get rid of this ASAP once std::format is out.
src/process/process.h:          // TODO: See above.
@fs-c fs-c added the enhancement New feature or request label Jun 28, 2020
@fs-c fs-c changed the title Repay technical dept in increments Get rid of TODOs Jul 5, 2020
@fs-c
Copy link
Owner Author

fs-c commented Jul 10, 2020

Some points that aren't on the above list

  • The distinction between stuff that should be done in the maniac namespace and stuff that should be done in main.cpp is unclear.
  • I dislike how the whole osu::internal thing is handled, there should be a nicer wrapper around the raw structs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant