-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_extract_datatree_chunk_index fails with eccodes v2.38.0 #508
Comments
@Anu-Ra-g , you already started to look into this, some details are in the linked thread. |
That's consistent with what I was seeing. |
|
I don't know what eccodes might be doing, but for the sake of the test, I would compare absolute offsets for the messages we know should be there, rather by index value. One alternative would be to add an empty row to the output when reading failed. |
(or we could pin the version of eccodes, of course, but that's unfortunate) |
I'm not so familiar with the intricacies of this GRIB, and I don't know if eccodes is using semver, but it seems to me like there's a breaking change in v2.38.0, perhaps a bug, especially since it's failing to read some of the variables. Unless we're doing something sketchy in this test so that the variables aren't well-defined, perhaps we should temporarily pin |
I agree, if we can show a reproducer locally with different outputs for the new version of eccodes compared to the previous one, that would be a good issue to post. |
Reproduce using the |
No, with eccodes/cfgrib directly, not touching any of our code at all. |
I looked into pinning eccodes, and the situation is pretty messy. It's not a direct dependency of kerchunk, but rather transitive through There's an easy conda solution to this problem: we just need to add a We could also add a warning when the user runs a grib function with v2.38. |
Correct, pip runs through the list of things to install in order. So if you include "eccodes<2.38" in your command after kerchunk (or as a separate command, or later in a pipenv file) all will be well.
Let's make that issue and see if there's any immediate follow-up from them. Honestly, eccodes, changes slightly every release, and things break all the time. I can only assume that typical use via xarray/cfgrib doesn't touch those sharp edges. |
As first noticed in #506, a test is failing when eccodes v2.38.0 is installed.
Observed in CI:
Troubleshooting by @maresb:
From @Anu-Ra-g with eccodes v2.36.0:
The text was updated successfully, but these errors were encountered: