Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching broken for custom client (should be an easy fix) #104

Closed
ListLostLisp opened this issue Jun 28, 2024 · 3 comments
Closed

Searching broken for custom client (should be an easy fix) #104

ListLostLisp opened this issue Jun 28, 2024 · 3 comments

Comments

@ListLostLisp
Copy link

ListLostLisp commented Jun 28, 2024

I am using an old app that should work with this service, but it is using a different way to search.

it searches for /feeds/api/videos?vq=test&start-index=1&max-results=10
The v in ?vq breaks the searching. I was able to setup a crude proxy to edit the html on the fly to remove the v and after a few attempts I was able to view results on the app (my proxy was very slow for some reason and it kept timing out.)

I'm sorry I can't really read code so I was unable to find where I could add this. If you don't want to add this to the repo could you atleast guide me where to look?

Here is some proof that it's not a mistake on the apps end.
https://web.archive.org/web/20100208214639/http://code.google.com/apis/youtube/migration.html

@gohoski
Copy link

gohoski commented Jul 10, 2024

This not only affects this custom client, but also the 1.4.20 (and possibly earlier) versions of the official YouTube app (although with /proxy added before the endpoint, see #106):

mFeedMap.put(YouTubeUrlType.SEARCH, new FeedInfo(appendCountryRestriction("proxy/feeds/api/videos?vq=%1$s&format=2")));

(code from a decompiled APK)

@mrkrabs206
Copy link

I am using an old app that should work with this service, but it is using a different way to search.

it searches for /feeds/api/videos?vq=test&start-index=1&max-results=10 The v in ?vq breaks the searching. I was able to setup a crude proxy to edit the html on the fly to remove the v and after a few attempts I was able to view results on the app (my proxy was very slow for some reason and it kept timing out.)

I'm sorry I can't really read code so I was unable to find where I could add this. If you don't want to add this to the repo could you atleast guide me where to look?

Here is some proof that it's not a mistake on the apps end. https://web.archive.org/web/20100208214639/http://code.google.com/apis/youtube/migration.html

Can you give us a photo

@ListLostLisp
Copy link
Author

I changed all mentions of "req.query.q" in yt2009 to "req.query.vq" and that fixed it.
The app now shows results but doesn't seem to parse the xml correctly to load the video links, but that's a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants