Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageMaker - Create data representation model #65

Merged
merged 7 commits into from
Oct 19, 2024
Merged

ImageMaker - Create data representation model #65

merged 7 commits into from
Oct 19, 2024

Conversation

fummicc1
Copy link
Owner

@fummicc1 fummicc1 commented Oct 16, 2024 •
edited
Loading

  • Define new object that represents ImageOutput structure
  • Separate logic into building layout and rendering image
  • Fix iOS image resolution problem: fit with device's resolution.

@fummicc1 fummicc1 changed the base branch from main to feature/rename-target October 16, 2024 15:47
Base automatically changed from feature/rename-target to main October 16, 2024 15:56
@fummicc1 fummicc1 marked this pull request as ready for review October 16, 2024 15:58
@fummicc1 fummicc1 marked this pull request as draft October 16, 2024 16:39
@fummicc1 fummicc1 linked an issue Oct 18, 2024 that may be closed by this pull request
[csv2img]: Extract output data into a model object. #62
Open
fummicc1
fummicc1 commented Oct 18, 2024
View reviewed changes
Fixtures/outputs/category.png
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review-note

I should check this diff later.

@fummicc1 fummicc1 marked this pull request as ready for review October 18, 2024 20:21
@fummicc1 fummicc1 merged commit 7849196 into main Oct 19, 2024
4 checks passed
@fummicc1 fummicc1 deleted the feature/#62 branch October 19, 2024 04:25
@fummicc1 fummicc1 mentioned this pull request Oct 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[csv2img]: Extract output data into a model object.
1 participant
@fummicc1