Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override arity for subscribe to not send end callback #10

Closed
Alotor opened this issue Dec 6, 2015 · 3 comments
Closed

Override arity for subscribe to not send end callback #10

Alotor opened this issue Dec 6, 2015 · 3 comments

Comments

@Alotor
Copy link
Contributor

Alotor commented Dec 6, 2015

Now the subscribe function needs to send the 3 functions (on-value, on-error, on-end) but the on-end is seldom needed.

Would be cool to support both arities (3 and 4)
niwinz added a commit that referenced this issue Dec 6, 2015
@niwinz
Add more arities to subscribe function.
c8635aa 
Fixes #10
@niwinz
Copy link
Member

niwinz commented Dec 6, 2015

Is that referenced commit is that you are expecting?

@Alotor
Copy link
Contributor Author

Alotor commented Dec 6, 2015

Yes :)

@Alotor Alotor closed this as completed Dec 6, 2015
@niwinz
Copy link
Member

niwinz commented Dec 6, 2015

Deployed latest snapshot with the change! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niwinz @Alotor