New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Observable.fromEvent wrapper #29

Closed

pepe opened this issue May 23, 2017 · 1 comment

Contributor

pepe commented May 23, 2017

Hello, as always thank you for the great libraries I highly appreciate all the work!

I am thinking about replacing this code: https://github.com/pepe/showrum/blob/master/src/cljs/showrum/app.cljs#L19-L22 with reactive stream and for this purpose JS method Observable.fromEvent() seems to be appropriate.

I would like to add a wrapper for the method to beicon, but I am not sure if it is not out of the scope of the library.

Please let me know, what you think.

Member

niwinz commented May 23, 2017

PR is welcome for that :D

niwinz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment