Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coercions are private but useful elsewhere and so should be made public again #44

Closed
jconti opened this issue May 13, 2019 · 1 comment · Fixed by #45
Closed

Coercions are private but useful elsewhere and so should be made public again #44

jconti opened this issue May 13, 2019 · 1 comment · Fixed by #45

Comments

@jconti
Copy link
Contributor

jconti commented May 13, 2019

It is often useful to use the coercions from beicon in user code to adapt normal functions to the types required by RxJava, without having to change beicon itself, or add to the beicon library unnecessarily:

(RxJavaPlugins/setErrorHandler (rx/as-consumer global-error-fn))

I think they are useful left public, and alter no state or otherwise have a reason to be private. This, I think, was previously understood, but maybe forgotten:

#42 (comment)

@niwinz
Copy link
Member

niwinz commented May 14, 2019

PR welcome ;)

jconti added a commit to jconti/beicon that referenced this issue May 14, 2019
niwinz pushed a commit that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants