-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renpy 7.x support #49
Comments
It should be supported. Can you send me a screenshot of the folder in question? |
Does |
Should be a pretty simple fix then, just need to look in both of these directories. Thanks for reporting this bug! |
The code I wrote for the RPE does not support Python 2, so I need to look into this as well |
Combing over the code, supporting Python 2 would be a pretty significant maintenance burden. I'm not sure how many people are still on Ren'Py 7, but it might be valuable to support this |
I can understand that. Thank you for looking into it. |
Unfortunately it looks like Ren'Py 7 and below does not have a websockets client installed, so implementing the app as it currently exists is impossible |
To elaborate on this, an earlier implementation of this program used IPC to do communication. Though I ended up nixing that so that launched programs didn't use pipes, as they're required for that method. Thinking about it again, going that route makes async/await a bit more wacky, you would need an intermediate process that won't quit with Visual Studio Code. Neither option I like very much for Renpy 7, which is on its way out with the next release. I'm also not very interested in supporting two methods. Hard to fit everything in. I'm working on a minimal update to support launching and quitting on Renpy 7, but it will not support any of the RPE features. I'll see where it goes from there. |
I went ahead and updated to 8.3.0. Expected many errors as I tried doing it once before and couldn't load a single save, but surprisingly it works very well now. I managed to resolve all or most issues in about 2 hours work. Tested the extension and it works flawlessly too. As you said, difficult to say how many people are still using it but it may be quicker for them to simply update it. Thank you for the hard work. |
Trying to set the path for D:\Program Files (x86)\renpy-7.6.0-sdk but getting an error saying Path is not RenPy SDK. Is Renpy 7.x supported?
The text was updated successfully, but these errors were encountered: